chrome/browser/ui/webui/settings/settings_manage_profile_handler_unittest.cc - Issue 1988463002: MD Settings: Convert C++ handlers to be JavaScript-lifecycle aware.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/settings/settings_manage_profile_handler_unittest.cc

Issue 1988463002: MD Settings: Convert C++ handlers to be JavaScript-lifecycle aware. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/settings/settings_manage_profile_handler.cc ('k') | chrome/browser/ui/webui/settings/settings_page_ui_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/settings/settings_manage_profile_handler_unittest.cc

diff --git a/chrome/browser/ui/webui/settings/settings_manage_profile_handler_unittest.cc b/chrome/browser/ui/webui/settings/settings_manage_profile_handler_unittest.cc

index 49d57ab839f22e87e6fe0c016e07cc7f399d84ab..63bf918ac5755e579272525106581036405fd177 100644

--- a/chrome/browser/ui/webui/settings/settings_manage_profile_handler_unittest.cc

+++ b/chrome/browser/ui/webui/settings/settings_manage_profile_handler_unittest.cc

@@ -24,6 +24,7 @@ class TestManageProfileHandler : public ManageProfileHandler {

: ManageProfileHandler(profile) {}

using ManageProfileHandler::set_web_ui;

+ using ManageProfileHandler::AllowJavascript;

};

} // namespace

@@ -40,6 +41,8 @@ class ManageProfileHandlerTest : public testing::Test {

handler_.reset(new TestManageProfileHandler(profile_));

handler_->set_web_ui(&web_ui_);

+ handler()->AllowJavascript();

+ web_ui()->ClearTrackedCalls();

}

void VerifyIconList(const base::Value* value) {