Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Side by Side Diff: chrome/browser/ui/webui/settings/settings_default_browser_handler.h

Issue 1988463002: MD Settings: Convert C++ handlers to be JavaScript-lifecycle aware. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_WEBUI_SETTINGS_SETTINGS_DEFAULT_BROWSER_HANDLER_H_ 5 #ifndef CHROME_BROWSER_UI_WEBUI_SETTINGS_SETTINGS_DEFAULT_BROWSER_HANDLER_H_
6 #define CHROME_BROWSER_UI_WEBUI_SETTINGS_SETTINGS_DEFAULT_BROWSER_HANDLER_H_ 6 #define CHROME_BROWSER_UI_WEBUI_SETTINGS_SETTINGS_DEFAULT_BROWSER_HANDLER_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "base/memory/weak_ptr.h" 9 #include "base/memory/weak_ptr.h"
10 #include "chrome/browser/profiles/profile.h" 10 #include "chrome/browser/profiles/profile.h"
(...skipping 14 matching lines...) Expand all
25 // The application used by the OS to open web documents (e.g. *.html) 25 // The application used by the OS to open web documents (e.g. *.html)
26 // is the "default browser". This class is an API for the JavaScript 26 // is the "default browser". This class is an API for the JavaScript
27 // settings code to change the default browser settings. 27 // settings code to change the default browser settings.
28 class DefaultBrowserHandler : public SettingsPageUIHandler { 28 class DefaultBrowserHandler : public SettingsPageUIHandler {
29 public: 29 public:
30 explicit DefaultBrowserHandler(content::WebUI* webui); 30 explicit DefaultBrowserHandler(content::WebUI* webui);
31 ~DefaultBrowserHandler() override; 31 ~DefaultBrowserHandler() override;
32 32
33 // SettingsPageUIHandler implementation. 33 // SettingsPageUIHandler implementation.
34 void RegisterMessages() override; 34 void RegisterMessages() override;
35 void OnJavascriptAllowed() override;
36 void OnJavascriptDisallowed() override;
35 37
36 private: 38 private:
37 // Called from WebUI to request the current state. 39 // Called from WebUI to request the current state.
38 void RequestDefaultBrowserState(const base::ListValue* args); 40 void RequestDefaultBrowserState(const base::ListValue* args);
39 41
40 // Makes this the default browser. Called from WebUI. 42 // Makes this the default browser. Called from WebUI.
41 void SetAsDefaultBrowser(const base::ListValue* args); 43 void SetAsDefaultBrowser(const base::ListValue* args);
42 44
43 // Called with the default browser state when the DefaultBrowserWorker is 45 // Called with the default browser state when the DefaultBrowserWorker is
44 // done. 46 // done.
45 void OnDefaultBrowserWorkerFinished( 47 void OnDefaultBrowserWorkerFinished(
46 shell_integration::DefaultWebClientState state); 48 shell_integration::DefaultWebClientState state);
47 49
48 // Reference to a background worker that handles default browser settings. 50 // Reference to a background worker that handles default browser settings.
49 scoped_refptr<shell_integration::DefaultBrowserWorker> 51 scoped_refptr<shell_integration::DefaultBrowserWorker>
50 default_browser_worker_; 52 default_browser_worker_;
51 53
52 // Policy setting to determine if default browser setting is managed. 54 // Policy setting to determine if default browser setting is managed.
53 BooleanPrefMember default_browser_policy_; 55 BooleanPrefMember default_browser_policy_;
54 56
55 // Used to invalidate the DefaultBrowserWorker callback. 57 // Used to invalidate the DefaultBrowserWorker callback.
56 base::WeakPtrFactory<DefaultBrowserHandler> weak_ptr_factory_; 58 base::WeakPtrFactory<DefaultBrowserHandler> weak_ptr_factory_;
57 59
58 DISALLOW_COPY_AND_ASSIGN(DefaultBrowserHandler); 60 DISALLOW_COPY_AND_ASSIGN(DefaultBrowserHandler);
59 }; 61 };
60 62
61 } // namespace settings 63 } // namespace settings
62 64
63 #endif // CHROME_BROWSER_UI_WEBUI_SETTINGS_SETTINGS_DEFAULT_BROWSER_HANDLER_H_ 65 #endif // CHROME_BROWSER_UI_WEBUI_SETTINGS_SETTINGS_DEFAULT_BROWSER_HANDLER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698