Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 1979963002: Remove OwnPtr::release() calls in platform/ (part inspector). (Closed)

Created:
4 years, 7 months ago by Yuta Kitamura
Modified:
4 years, 7 months ago
Reviewers:
*pfeldman, *tzik
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kinuko+watch, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove OwnPtr::release() calls in platform/ (part inspector). OwnPtr::release() calls can be (1) replaced with std::move(), or (2) removed entirely (in certain "return" statements). BUG=611660 Committed: https://crrev.com/e140a0d3266c78fb085395cf63eb75778fc4413d Cr-Commit-Position: refs/heads/master@{#394341}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -84 lines) Patch
M third_party/WebKit/Source/platform/inspector_protocol/Array.h View 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/Dispatcher_cpp.template View 8 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/Frontend_cpp.template View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/Parser.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_cpp.template View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_h.template View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/Values.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/RemoteObjectId.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp View 12 chunks +13 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp View 10 chunks +13 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.cpp View 4 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1979963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1979963002/1
4 years, 7 months ago (2016-05-16 06:45:19 UTC) #2
Yuta Kitamura
tzik: PTAL? pfeldman: Can you give an approval for platform/inspector-protocol/ and platform/v8_inspector/? Also, can you ...
4 years, 7 months ago (2016-05-16 06:49:28 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-16 08:45:50 UTC) #7
tzik
lgtm
4 years, 7 months ago (2016-05-16 09:21:06 UTC) #8
Yuta Kitamura
pfeldman: Ping?
4 years, 7 months ago (2016-05-17 08:07:06 UTC) #9
pfeldman
lgtm
4 years, 7 months ago (2016-05-17 17:24:17 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1979963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1979963002/1
4 years, 7 months ago (2016-05-18 03:32:22 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/192141)
4 years, 7 months ago (2016-05-18 04:56:33 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1979963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1979963002/1
4 years, 7 months ago (2016-05-18 05:28:57 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-18 06:16:49 UTC) #17
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 06:18:51 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e140a0d3266c78fb085395cf63eb75778fc4413d
Cr-Commit-Position: refs/heads/master@{#394341}

Powered by Google App Engine
This is Rietveld 408576698