third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_cpp.template - Issue 1979963002: Remove OwnPtr::release() calls in platform/ (part inspector).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_cpp.template

Issue 1979963002: Remove OwnPtr::release() calls in platform/ (part inspector). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/inspector_protocol/Parser.cpp ('k') | third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_h.template » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_cpp.template

diff --git a/third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_cpp.template b/third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_cpp.template

index 229a0cbe50ba21b430901cf0d2d101c1ee867d82..e0a799727d46e0118bcb07ead0cfaf1fafb7b700 100644

--- a/third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_cpp.template

+++ b/third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_cpp.template

@@ -80,7 +80,7 @@ PassOwnPtr<{{type.id}}> {{type.id}}::parse(protocol::Value* value, ErrorSupport*

errors->pop();

if (errors->hasErrors())

return nullptr;

- return result.release();

+ return result;

}

PassOwnPtr<protocol::DictionaryValue> {{type.id}}::serialize() const

@@ -94,7 +94,7 @@ PassOwnPtr<protocol::DictionaryValue> {{type.id}}::serialize() const

result->setValue("{{property.name}}", toValue({{resolve_type(property).to_raw_type % ("m_" + property.name)}}));

{% endif %}

{% endfor %}

- return result.release();

+ return result;

}

PassOwnPtr<{{type.id}}> {{type.id}}::clone() const