Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1147)

Unified Diff: third_party/WebKit/Source/platform/inspector_protocol/Array.h

Issue 1979963002: Remove OwnPtr::release() calls in platform/ (part inspector). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/inspector_protocol/Array.h
diff --git a/third_party/WebKit/Source/platform/inspector_protocol/Array.h b/third_party/WebKit/Source/platform/inspector_protocol/Array.h
index e740988a897f2af984bb95430d28b4e30b62c17a..015d07b1c08690b3b591a112a912280351d1bb8f 100644
--- a/third_party/WebKit/Source/platform/inspector_protocol/Array.h
+++ b/third_party/WebKit/Source/platform/inspector_protocol/Array.h
@@ -40,7 +40,7 @@ public:
errors->pop();
if (errors->hasErrors())
return nullptr;
- return result.release();
+ return result;
}
void addItem(const T& value)
@@ -63,7 +63,7 @@ public:
OwnPtr<protocol::ListValue> result = ListValue::create();
for (auto& item : m_vector)
result->pushValue(toValue(item));
- return result.release();
+ return result;
}
private:
@@ -96,12 +96,12 @@ public:
for (size_t i = 0; i < array->size(); ++i) {
errors->setName(String16::number(i));
OwnPtr<T> item = FromValue<T>::parse(array->at(i), errors);
- result->m_vector.append(item.release());
+ result->m_vector.append(std::move(item));
}
errors->pop();
if (errors->hasErrors())
return nullptr;
- return result.release();
+ return result;
}
void addItem(PassOwnPtr<T> value)
@@ -124,7 +124,7 @@ public:
OwnPtr<protocol::ListValue> result = ListValue::create();
for (auto& item : m_vector)
result->pushValue(toValue(item.get()));
- return result.release();
+ return result;
}
private:
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698