Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp

Issue 1979963002: Remove OwnPtr::release() calls in platform/ (part inspector). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp
diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp
index 84338fee8042dcf53de200f77c995f9923509c92..56cbcf0877864cbd2fa02910811c191fccea7fce 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp
+++ b/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp
@@ -236,11 +236,11 @@ void V8RuntimeAgentImpl::getProperties(
return;
propertiesProtocolArray->addItem(InternalPropertyDescriptor::create()
.setName(toProtocolString(name.As<v8::String>()))
- .setValue(wrappedValue.release()).build());
+ .setValue(std::move(wrappedValue)).build());
}
if (!propertiesProtocolArray->length())
return;
- *internalProperties = propertiesProtocolArray.release();
+ *internalProperties = std::move(propertiesProtocolArray);
}
void V8RuntimeAgentImpl::releaseObject(ErrorString* errorString, const String16& objectId)
@@ -298,7 +298,7 @@ void V8RuntimeAgentImpl::compileScript(ErrorString* errorString,
String16 scriptValueId = String16::number(script->GetUnboundScript()->GetId());
OwnPtr<v8::Global<v8::Script>> global = adoptPtr(new v8::Global<v8::Script>(m_debugger->isolate(), script));
- m_compiledScripts.set(scriptValueId, global.release());
+ m_compiledScripts.set(scriptValueId, std::move(global));
*scriptId = scriptValueId;
}
@@ -420,7 +420,7 @@ void V8RuntimeAgentImpl::reportExecutionContextCreated(InspectedContext* context
.setName(context->humanReadableName())
.setOrigin(context->origin())
.setFrameId(context->frameId()).build();
- m_frontend->executionContextCreated(description.release());
+ m_frontend->executionContextCreated(std::move(description));
}
void V8RuntimeAgentImpl::reportExecutionContextDestroyed(InspectedContext* context)

Powered by Google App Engine
This is Rietveld 408576698