third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp - Issue 1979963002: Remove OwnPtr::release() calls in platform/ (part inspector).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp

Issue 1979963002: Remove OwnPtr::release() calls in platform/ (part inspector). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp

index f5bc036b8eec72faf66919ee01cbeb24b0d5df71..4323af3d0a987212e8fad6023bdb756808d6bf2e 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp

@@ -139,7 +139,7 @@ public:

statsDiff->addItem(updateData[i].count);

statsDiff->addItem(updateData[i].size);

}

- m_frontend->heapStatsUpdate(statsDiff.release());

+ m_frontend->heapStatsUpdate(std::move(statsDiff));

return kContinue;

}

@@ -379,7 +379,7 @@ PassOwnPtr<protocol::HeapProfiler::SamplingHeapProfileNode> buildSampingHeapProf

.setColumnNumber(node->column_number)

.setSelfSize(selfSize)

.setChildren(std::move(children)).build();

- return result.release();

+ return result;

}

} // namespace

#endif