third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp - Issue 1979963002: Remove OwnPtr::release() calls in platform/ (part inspector).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp

Issue 1979963002: Remove OwnPtr::release() calls in platform/ (part inspector). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp

index 40898de5fe687da4975d8cd6987015b205eab5c9..18993612da751790105bf04726319f71d9bf5eda 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp

@@ -741,7 +741,7 @@ PassOwnPtr<V8InspectorSession> V8DebuggerImpl::connect(int contextGroupId)

ASSERT(!m_sessions.contains(contextGroupId));

OwnPtr<V8InspectorSessionImpl> session = V8InspectorSessionImpl::create(this, contextGroupId);

m_sessions.set(contextGroupId, session.get());

- return session.release();

+ return std::move(session);

}

void V8DebuggerImpl::disconnect(V8InspectorSessionImpl* session)

@@ -766,7 +766,7 @@ void V8DebuggerImpl::contextCreated(const V8ContextInfo& info)

OwnPtr<InspectedContext> contextOwner = adoptPtr(new InspectedContext(this, info, contextId));

InspectedContext* inspectedContext = contextOwner.get();

- m_contexts.get(info.contextGroupId)->set(contextId, contextOwner.release());

+ m_contexts.get(info.contextGroupId)->set(contextId, std::move(contextOwner));

if (V8InspectorSessionImpl* session = m_sessions.get(info.contextGroupId))

session->runtimeAgentImpl()->reportExecutionContextCreated(inspectedContext);