third_party/WebKit/Source/platform/inspector_protocol/Values.cpp - Issue 1979963002: Remove OwnPtr::release() calls in platform/ (part inspector).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/inspector_protocol/Values.cpp

Issue 1979963002: Remove OwnPtr::release() calls in platform/ (part inspector). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_h.template ('k') | third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/inspector_protocol/Values.cpp

diff --git a/third_party/WebKit/Source/platform/inspector_protocol/Values.cpp b/third_party/WebKit/Source/platform/inspector_protocol/Values.cpp

index 8c0bac1169e4c46e13621a7e868b23eb83e18be1..0471d901ee5a82acaad94100cc0b0797663ba6f6 100644

--- a/third_party/WebKit/Source/platform/inspector_protocol/Values.cpp

+++ b/third_party/WebKit/Source/platform/inspector_protocol/Values.cpp

@@ -301,7 +301,7 @@ PassOwnPtr<Value> DictionaryValue::clone() const

ASSERT(value);

result->setValue(key, value->clone());

}

- return result.release();

+ return std::move(result);

}

DictionaryValue::DictionaryValue()

@@ -329,7 +329,7 @@ PassOwnPtr<Value> ListValue::clone() const

OwnPtr<ListValue> result = ListValue::create();

for (Vector<OwnPtr<protocol::Value>>::const_iterator it = m_data.begin(); it != m_data.end(); ++it)

result->pushValue((*it)->clone());

- return result.release();

+ return std::move(result);

}

ListValue::ListValue()