Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1630)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.cpp

Issue 1979963002: Remove OwnPtr::release() calls in platform/ (part inspector). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.cpp
diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.cpp
index e850dd5c4d29e85c148d4a574548814e5ab32ec5..50ab02a43e01a3703a281b872ea2132efae050e7 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.cpp
+++ b/third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.cpp
@@ -110,7 +110,7 @@ PassOwnPtr<protocol::Vector<unsigned>> lineEndings(const String16& text)
}
result->append(text.length());
- return result.release();
+ return result;
}
protocol::Vector<std::pair<int, String16>> scriptRegexpMatchesByLines(const V8Regex& regex, const String16& text)
@@ -204,7 +204,7 @@ PassOwnPtr<protocol::Array<protocol::Debugger::SearchMatch>> searchInTextByLines
for (const auto& match : matches)
result->addItem(buildObjectForSearchMatch(match.first, match.second));
- return result.release();
+ return result;
}
} // namespace V8ContentSearchUtil
@@ -239,9 +239,9 @@ PassOwnPtr<protocol::Value> toProtocolValue(v8::Local<v8::Context> context, v8::
OwnPtr<protocol::Value> element = toProtocolValue(context, value, maxDepth);
if (!element)
return nullptr;
- inspectorArray->pushValue(element.release());
+ inspectorArray->pushValue(std::move(element));
}
- return inspectorArray.release();
+ return std::move(inspectorArray);
}
if (value->IsObject()) {
OwnPtr<protocol::DictionaryValue> jsonObject = protocol::DictionaryValue::create();
@@ -269,9 +269,9 @@ PassOwnPtr<protocol::Value> toProtocolValue(v8::Local<v8::Context> context, v8::
OwnPtr<protocol::Value> propertyValue = toProtocolValue(context, property, maxDepth);
if (!propertyValue)
return nullptr;
- jsonObject->setValue(toProtocolString(propertyName), propertyValue.release());
+ jsonObject->setValue(toProtocolString(propertyName), std::move(propertyValue));
}
- return jsonObject.release();
+ return std::move(jsonObject);
}
ASSERT_NOT_REACHED();
return nullptr;
« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698