Issue 197873022: Drop Element::isHTMLFrameElementBase() virtual function

Issue 197873022: Drop Element::isHTMLFrameElementBase() virtual function (Closed)

Created:
6 years, 9 months ago by Inactive

Modified:
6 years, 9 months ago

Reviewers:
tkent, adamk

CC:
blink-reviews, aboxhall, sof, eae+blinkwatch, ed+blinkwatch_opera.com, dglazkov+blink, dmazzoni, apavlov+blink_chromium.org, adamk+blink_chromium.org, darktears, rwlbuis, Inactive, rune+blink

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Drop Element::isHTMLFrameElementBase() virtual function Drop Element::isHTMLFrameElementBase() virtual function and have isHTMLFrameElementBase() helper use the isHTML*Element() helpers instead. This is more consistent with other HTML Elements and simplifies the code a little bit. R=tkent, adamk BUG=346095 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169446

Patch Set 1 #

Total comments: 6

Patch Set 2 : Take tkent's feedback into consideration #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -24 lines)			Patch
M	Source/core/accessibility/AXNodeObject.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/css/SelectorChecker.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/dom/Element.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/dom/Element.cpp	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/editing/FrameSelection.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/html/HTMLBodyElement.cpp	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	Source/core/html/HTMLFrameElementBase.h	View		2 chunks	+6 lines, -3 lines	0 comments	Download
M	Source/core/page/EventHandler.cpp	View		1 chunk	+1 line, -4 lines	0 comments	Download
M	Source/web/TextFinder.cpp	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/web/WebFrameImpl.cpp	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download
M	Source/web/WebPageSerializer.cpp	View	1	2 chunks	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

tkent

lgtm https://codereview.chromium.org/197873022/diff/1/Source/web/TextFinder.cpp File Source/web/TextFinder.cpp (right): https://codereview.chromium.org/197873022/diff/1/Source/web/TextFinder.cpp#newcode2226 Source/web/TextFinder.cpp:2226: if (!isHTMLFrameElementBase(element) || !element->isFrameOwnerElement()) element->isFrameOwnerElement() is unnecessary because ...

6 years, 9 months ago (2014-03-17 22:30:25 UTC) #2

Inactive

https://codereview.chromium.org/197873022/diff/1/Source/web/TextFinder.cpp File Source/web/TextFinder.cpp (right): https://codereview.chromium.org/197873022/diff/1/Source/web/TextFinder.cpp#newcode2226 Source/web/TextFinder.cpp:2226: if (!isHTMLFrameElementBase(element) || !element->isFrameOwnerElement()) On 2014/03/17 22:30:25, tkent wrote: ...

6 years, 9 months ago (2014-03-17 23:36:59 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/197873022/10001

6 years, 9 months ago (2014-03-17 23:37:19 UTC) #5

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

6 years, 9 months ago (2014-03-18 03:23:31 UTC) #6

commit-bot: I haz the power

Commit queue rejected this change because the description was changed between the time the change ...

6 years, 9 months ago (2014-03-18 03:23:32 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/197873022/10001

6 years, 9 months ago (2014-03-18 12:54:27 UTC) #9

Message was sent while issue was closed.

Change committed as 169446

Expand Messages | Collapse Messages