Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(880)

Unified Diff: Source/core/page/EventHandler.cpp

Issue 197873022: Drop Element::isHTMLFrameElementBase() virtual function (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Take tkent's feedback into consideration Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/HTMLFrameElementBase.h ('k') | Source/web/TextFinder.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/page/EventHandler.cpp
diff --git a/Source/core/page/EventHandler.cpp b/Source/core/page/EventHandler.cpp
index 5a64465f68bcfa03fcd3294d24c9b534b26d7472..e0301a0034d9d5e7edd6564342e4facd19597c63 100644
--- a/Source/core/page/EventHandler.cpp
+++ b/Source/core/page/EventHandler.cpp
@@ -1745,10 +1745,7 @@ bool EventHandler::dispatchDragEvent(const AtomicString& eventType, Node* dragTa
static bool targetIsFrame(Node* target, LocalFrame*& frame)
{
- if (!target)
- return false;
-
- if (!isHTMLFrameElement(*target) && !isHTMLIFrameElement(*target))
+ if (!isHTMLFrameElementBase(target))
return false;
frame = toHTMLFrameElementBase(target)->contentFrame();
« no previous file with comments | « Source/core/html/HTMLFrameElementBase.h ('k') | Source/web/TextFinder.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698