Source/core/html/HTMLBodyElement.cpp - Issue 197873022: Drop Element::isHTMLFrameElementBase() virtual function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLBodyElement.cpp

Issue 197873022: Drop Element::isHTMLFrameElementBase() virtual function (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Take tkent's feedback into consideration Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/HTMLBodyElement.cpp

diff --git a/Source/core/html/HTMLBodyElement.cpp b/Source/core/html/HTMLBodyElement.cpp

index 10882eac5d59c043e360ac1d768b6a558226c640..a2acd1aae8d5e7cbf074a85c9510b91ad9761b94 100644

--- a/Source/core/html/HTMLBodyElement.cpp

+++ b/Source/core/html/HTMLBodyElement.cpp

@@ -161,12 +161,12 @@ Node::InsertionNotificationRequest HTMLBodyElement::insertedInto(ContainerNode*

// and marginheight attribute can magically appear on the <body> of all documents

// embedded through <iframe> or <frame>.

Element* ownerElement = document().ownerElement();

- if (ownerElement && ownerElement->isFrameElementBase()) {

- HTMLFrameElementBase* ownerFrameElement = toHTMLFrameElementBase(ownerElement);

- int marginWidth = ownerFrameElement->marginWidth();

+ if (isHTMLFrameElementBase(ownerElement)) {

+ HTMLFrameElementBase& ownerFrameElement = toHTMLFrameElementBase(*ownerElement);

+ int marginWidth = ownerFrameElement.marginWidth();

if (marginWidth != -1)

setIntegralAttribute(marginwidthAttr, marginWidth);

- int marginHeight = ownerFrameElement->marginHeight();

+ int marginHeight = ownerFrameElement.marginHeight();

if (marginHeight != -1)

setIntegralAttribute(marginheightAttr, marginHeight);

}

« no previous file with comments | « Source/core/editing/FrameSelection.cpp ('k') | Source/core/html/HTMLFrameElementBase.h » ('j') | no next file with comments »