Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Side by Side Diff: Source/core/html/HTMLFrameElementBase.h

Issue 197873022: Drop Element::isHTMLFrameElementBase() virtual function (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Take tkent's feedback into consideration Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/html/HTMLBodyElement.cpp ('k') | Source/core/page/EventHandler.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Simon Hausmann <hausmann@kde.org> 4 * (C) 2000 Simon Hausmann <hausmann@kde.org>
5 * Copyright (C) 2004, 2006, 2008, 2009 Apple Inc. All rights reserved. 5 * Copyright (C) 2004, 2006, 2008, 2009 Apple Inc. All rights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
54 virtual void didNotifySubtreeInsertionsToDocument() OVERRIDE FINAL; 54 virtual void didNotifySubtreeInsertionsToDocument() OVERRIDE FINAL;
55 virtual void attach(const AttachContext& = AttachContext()) OVERRIDE; 55 virtual void attach(const AttachContext& = AttachContext()) OVERRIDE;
56 56
57 private: 57 private:
58 virtual bool supportsFocus() const OVERRIDE FINAL; 58 virtual bool supportsFocus() const OVERRIDE FINAL;
59 virtual void setFocus(bool) OVERRIDE FINAL; 59 virtual void setFocus(bool) OVERRIDE FINAL;
60 60
61 virtual bool isURLAttribute(const Attribute&) const OVERRIDE FINAL; 61 virtual bool isURLAttribute(const Attribute&) const OVERRIDE FINAL;
62 virtual bool isHTMLContentAttribute(const Attribute&) const OVERRIDE FINAL; 62 virtual bool isHTMLContentAttribute(const Attribute&) const OVERRIDE FINAL;
63 63
64 virtual bool isFrameElementBase() const OVERRIDE FINAL { return true; }
65
66 virtual bool areAuthorShadowsAllowed() const OVERRIDE FINAL { return false; } 64 virtual bool areAuthorShadowsAllowed() const OVERRIDE FINAL { return false; }
67 65
68 void setNameAndOpenURL(); 66 void setNameAndOpenURL();
69 void openURL(bool lockBackForwardList = true); 67 void openURL(bool lockBackForwardList = true);
70 68
71 AtomicString m_URL; 69 AtomicString m_URL;
72 AtomicString m_frameName; 70 AtomicString m_frameName;
73 71
74 ScrollbarMode m_scrolling; 72 ScrollbarMode m_scrolling;
75 73
76 int m_marginWidth; 74 int m_marginWidth;
77 int m_marginHeight; 75 int m_marginHeight;
78 }; 76 };
79 77
80 inline bool isHTMLFrameElementBase(const Node& node) 78 inline bool isHTMLFrameElementBase(const Node& node)
81 { 79 {
82 return node.isElementNode() && toElement(node).isFrameElementBase(); 80 return isHTMLFrameElement(node) || isHTMLIFrameElement(node);
81 }
82
83 inline bool isHTMLFrameElementBase(const Node* node)
84 {
85 return node && isHTMLFrameElementBase(*node);
83 } 86 }
84 87
85 DEFINE_ELEMENT_TYPE_CASTS_WITH_FUNCTION(HTMLFrameElementBase); 88 DEFINE_ELEMENT_TYPE_CASTS_WITH_FUNCTION(HTMLFrameElementBase);
86 89
87 } // namespace WebCore 90 } // namespace WebCore
88 91
89 #endif // HTMLFrameElementBase_h 92 #endif // HTMLFrameElementBase_h
OLDNEW
« no previous file with comments | « Source/core/html/HTMLBodyElement.cpp ('k') | Source/core/page/EventHandler.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698