Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Side by Side Diff: Source/core/dom/Element.cpp

Issue 197873022: Drop Element::isHTMLFrameElementBase() virtual function (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Take tkent's feedback into consideration Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/dom/Element.h ('k') | Source/core/editing/FrameSelection.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Peter Kelly (pmk@post.com) 4 * (C) 2001 Peter Kelly (pmk@post.com)
5 * (C) 2001 Dirk Mueller (mueller@kde.org) 5 * (C) 2001 Dirk Mueller (mueller@kde.org)
6 * (C) 2007 David Smith (catfish.man@gmail.com) 6 * (C) 2007 David Smith (catfish.man@gmail.com)
7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. All rights reserved. 7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. All rights reserved.
8 * (C) 2007 Eric Seidel (eric@webkit.org) 8 * (C) 2007 Eric Seidel (eric@webkit.org)
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
77 #include "core/events/FocusEvent.h" 77 #include "core/events/FocusEvent.h"
78 #include "core/frame/FrameView.h" 78 #include "core/frame/FrameView.h"
79 #include "core/frame/LocalFrame.h" 79 #include "core/frame/LocalFrame.h"
80 #include "core/frame/UseCounter.h" 80 #include "core/frame/UseCounter.h"
81 #include "core/frame/csp/ContentSecurityPolicy.h" 81 #include "core/frame/csp/ContentSecurityPolicy.h"
82 #include "core/html/ClassList.h" 82 #include "core/html/ClassList.h"
83 #include "core/html/HTMLCollection.h" 83 #include "core/html/HTMLCollection.h"
84 #include "core/html/HTMLDocument.h" 84 #include "core/html/HTMLDocument.h"
85 #include "core/html/HTMLElement.h" 85 #include "core/html/HTMLElement.h"
86 #include "core/html/HTMLFormControlsCollection.h" 86 #include "core/html/HTMLFormControlsCollection.h"
87 #include "core/html/HTMLFrameElementBase.h"
87 #include "core/html/HTMLFrameOwnerElement.h" 88 #include "core/html/HTMLFrameOwnerElement.h"
88 #include "core/html/HTMLLabelElement.h" 89 #include "core/html/HTMLLabelElement.h"
89 #include "core/html/HTMLOptionsCollection.h" 90 #include "core/html/HTMLOptionsCollection.h"
90 #include "core/html/HTMLTableRowsCollection.h" 91 #include "core/html/HTMLTableRowsCollection.h"
91 #include "core/html/HTMLTemplateElement.h" 92 #include "core/html/HTMLTemplateElement.h"
92 #include "core/html/parser/HTMLParserIdioms.h" 93 #include "core/html/parser/HTMLParserIdioms.h"
93 #include "core/inspector/InspectorInstrumentation.h" 94 #include "core/inspector/InspectorInstrumentation.h"
94 #include "core/page/FocusController.h" 95 #include "core/page/FocusController.h"
95 #include "core/page/Page.h" 96 #include "core/page/Page.h"
96 #include "core/page/PointerLockController.h" 97 #include "core/page/PointerLockController.h"
(...skipping 3425 matching lines...) Expand 10 before | Expand all | Expand 10 after
3522 return false; 3523 return false;
3523 if (this == document().cssTarget()) 3524 if (this == document().cssTarget())
3524 return false; 3525 return false;
3525 if (isHTMLElement() && toHTMLElement(this)->hasDirectionAuto()) 3526 if (isHTMLElement() && toHTMLElement(this)->hasDirectionAuto())
3526 return false; 3527 return false;
3527 if (hasActiveAnimations()) 3528 if (hasActiveAnimations())
3528 return false; 3529 return false;
3529 // Turn off style sharing for elements that can gain layers for reasons outs ide of the style system. 3530 // Turn off style sharing for elements that can gain layers for reasons outs ide of the style system.
3530 // See comments in RenderObject::setStyle(). 3531 // See comments in RenderObject::setStyle().
3531 // FIXME: Why does gaining a layer from outside the style system require dis abling sharing? 3532 // FIXME: Why does gaining a layer from outside the style system require dis abling sharing?
3532 if (isHTMLIFrameElement(*this) 3533 if (isHTMLFrameElementBase(*this)
3533 || isHTMLFrameElement(*this)
3534 || isHTMLEmbedElement(*this) 3534 || isHTMLEmbedElement(*this)
3535 || isHTMLObjectElement(*this) 3535 || isHTMLObjectElement(*this)
3536 || isHTMLAppletElement(*this) 3536 || isHTMLAppletElement(*this)
3537 || isHTMLCanvasElement(*this)) 3537 || isHTMLCanvasElement(*this))
3538 return false; 3538 return false;
3539 // FIXME: We should share style for option and optgroup whenever possible. 3539 // FIXME: We should share style for option and optgroup whenever possible.
3540 // Before doing so, we need to resolve issues in HTMLSelectElement::recalcLi stItems 3540 // Before doing so, we need to resolve issues in HTMLSelectElement::recalcLi stItems
3541 // and RenderMenuList::setText. See also https://bugs.webkit.org/show_bug.cg i?id=88405 3541 // and RenderMenuList::setText. See also https://bugs.webkit.org/show_bug.cg i?id=88405
3542 if (isHTMLOptionElement(*this) || isHTMLOptGroupElement(*this)) 3542 if (isHTMLOptionElement(*this) || isHTMLOptGroupElement(*this))
3543 return false; 3543 return false;
3544 if (FullscreenElementStack::isActiveFullScreenElement(this)) 3544 if (FullscreenElementStack::isActiveFullScreenElement(this))
3545 return false; 3545 return false;
3546 return true; 3546 return true;
3547 } 3547 }
3548 3548
3549 } // namespace WebCore 3549 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/dom/Element.h ('k') | Source/core/editing/FrameSelection.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698