Source/core/editing/FrameSelection.cpp - Issue 197873022: Drop Element::isHTMLFrameElementBase() virtual function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/FrameSelection.cpp

Issue 197873022: Drop Element::isHTMLFrameElementBase() virtual function (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Take tkent's feedback into consideration Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/editing/FrameSelection.cpp

diff --git a/Source/core/editing/FrameSelection.cpp b/Source/core/editing/FrameSelection.cpp

index 0c6083da2dbe8c3e0c54be10ef36358e84826cc6..d505320bc89b81913907799205e2ccb8db257927 100644

--- a/Source/core/editing/FrameSelection.cpp

+++ b/Source/core/editing/FrameSelection.cpp

@@ -1733,7 +1733,7 @@ static HTMLFormElement* scanForForm(Node* start)

if (HTMLFormElement* owner = element->formOwner())

return owner;

- if (isHTMLFrameElement(*element) || isHTMLIFrameElement(*element)) {

+ if (isHTMLFrameElementBase(*element)) {

Node* childDocument = toHTMLFrameElementBase(*element).contentDocument();

if (HTMLFormElement* frameResult = scanForForm(childDocument))

return frameResult;

« no previous file with comments | « Source/core/dom/Element.cpp ('k') | Source/core/html/HTMLBodyElement.cpp » ('j') | no next file with comments »