Source/core/accessibility/AXNodeObject.cpp - Issue 197873022: Drop Element::isHTMLFrameElementBase() virtual function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/accessibility/AXNodeObject.cpp

Issue 197873022: Drop Element::isHTMLFrameElementBase() virtual function (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Take tkent's feedback into consideration Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/accessibility/AXNodeObject.cpp

diff --git a/Source/core/accessibility/AXNodeObject.cpp b/Source/core/accessibility/AXNodeObject.cpp

index fa59758de580dea50ab555dffcddfbc70333931b..df7e9641f322296052ad3cbcf460aa70845d00c3 100644

--- a/Source/core/accessibility/AXNodeObject.cpp

+++ b/Source/core/accessibility/AXNodeObject.cpp

@@ -1620,7 +1620,7 @@ String AXNodeObject::alternativeTextForWebArea() const

Node* owner = document->ownerElement();

if (owner) {

- if (isHTMLFrameElement(*owner) || isHTMLIFrameElement(*owner)) {

+ if (isHTMLFrameElementBase(*owner)) {

const AtomicString& title = toElement(owner)->getAttribute(titleAttr);

if (!title.isEmpty())

return title;

« no previous file with comments | « no previous file | Source/core/css/SelectorChecker.cpp » ('j') | no next file with comments »