Source/core/dom/Element.cpp - Issue 197873022: Drop Element::isHTMLFrameElementBase() virtual function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Element.cpp

Issue 197873022: Drop Element::isHTMLFrameElementBase() virtual function (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Take tkent's feedback into consideration Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/dom/Element.cpp

diff --git a/Source/core/dom/Element.cpp b/Source/core/dom/Element.cpp

index 1b88ddbf87c87a51d523e8985ea2cfadeba4c3c7..f5e35beb63937283c925a1acf0c8b32147193365 100644

--- a/Source/core/dom/Element.cpp

+++ b/Source/core/dom/Element.cpp

@@ -84,6 +84,7 @@

#include "core/html/HTMLDocument.h"

#include "core/html/HTMLElement.h"

#include "core/html/HTMLFormControlsCollection.h"

+#include "core/html/HTMLFrameElementBase.h"

#include "core/html/HTMLFrameOwnerElement.h"

#include "core/html/HTMLLabelElement.h"

#include "core/html/HTMLOptionsCollection.h"

@@ -3529,8 +3530,7 @@ bool Element::supportsStyleSharing() const

// Turn off style sharing for elements that can gain layers for reasons outside of the style system.

// See comments in RenderObject::setStyle().

// FIXME: Why does gaining a layer from outside the style system require disabling sharing?

- if (isHTMLIFrameElement(*this)

- || isHTMLFrameElement(*this)

+ if (isHTMLFrameElementBase(*this)

|| isHTMLEmbedElement(*this)

|| isHTMLObjectElement(*this)

|| isHTMLAppletElement(*this)

« no previous file with comments | « Source/core/dom/Element.h ('k') | Source/core/editing/FrameSelection.cpp » ('j') | no next file with comments »