Add OpenGL context to Viewer.

Add OpenGL context to Viewer.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1978573003

Committed: https://skia.googlesource.com/skia/+/56a11e4d6f3d436a3c2497c9c9e71a117d78a93f

Committed: https://skia.googlesource.com/skia/+/af236b5aa9e7d71d59bee6533d16deb76e9d098b

[jvanverth1, 2016-05-12 20:42:20]

Description was changed from

==========
Add OpenGL context to Viewer.

BUG=skia:
==========

to

==========
Add OpenGL context to Viewer.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[jvanverth1, 2016-05-16 18:22:01]

jvanverth@google.com changed reviewers:
+ brianosman@google.com, bsalomon@google.com

[jvanverth1, 2016-05-16 18:22:02]

I think this will still compile on Windows after the Android fixes, but my
machine died so I can't verify.

[jvanverth1, 2016-05-16 18:22:27]

On 2016/05/16 18:22:02, jvanverth1 wrote:
> I think this will still compile on Windows after the Android fixes, but my
> machine died so I can't verify.

Well, maybe I could use a trybot (duh).

[jvanverth1, 2016-05-16 18:53:35]

On 2016/05/16 18:22:27, jvanverth1 wrote:
> On 2016/05/16 18:22:02, jvanverth1 wrote:
> > I think this will still compile on Windows after the Android fixes, but my
> > machine died so I can't verify.
> 
> Well, maybe I could use a trybot (duh).

The failure is not in this change (and I don't think it compiles the Viewer in
any case), so PTAL.

[Brian Osman, 2016-05-16 18:59:44]

https://codereview.chromium.org/1978573003/diff/80001/tools/viewer/sk_app/GLW...
File tools/viewer/sk_app/GLWindowContext.cpp (right):

https://codereview.chromium.org/1978573003/diff/80001/tools/viewer/sk_app/GLW...
tools/viewer/sk_app/GLWindowContext.cpp:90: SkSurfaceProps props(fSurfaceProps);
We should be setting the kGammaCorrect_Flag on the surface props, if
SkColorAndProfileAreGammaCorrect(fColorType, fProfileType).

[jvanverth1, 2016-05-16 19:04:01]

jvanverth@google.com changed reviewers:
+ djsollen@google.com

[jvanverth1, 2016-05-16 19:04:01]

Adding djsollen@ as well, for thoughts on how this affects Android.

[bsalomon, 2016-05-16 19:22:37]

Should we keep the deep color blit stuff out of the backend GL/vk code and into
an agnostic place, like the WindowContext base class?

[jvanverth1, 2016-05-16 20:36:39]

On 2016/05/16 19:22:37, bsalomon wrote:
> Should we keep the deep color blit stuff out of the backend GL/vk code and
into
> an agnostic place, like the WindowContext base class?

Yes, that makes sense.

[jvanverth1, 2016-05-17 15:37:18]

Updated to address comments. PTAL.

https://codereview.chromium.org/1978573003/diff/80001/tools/viewer/sk_app/GLW...
File tools/viewer/sk_app/GLWindowContext.cpp (right):

https://codereview.chromium.org/1978573003/diff/80001/tools/viewer/sk_app/GLW...
tools/viewer/sk_app/GLWindowContext.cpp:90: SkSurfaceProps props(fSurfaceProps);
On 2016/05/16 18:59:43, Brian Osman wrote:
> We should be setting the kGammaCorrect_Flag on the surface props, if
> SkColorAndProfileAreGammaCorrect(fColorType, fProfileType).

Done.

[Brian Osman, 2016-05-17 17:32:11]

lgtm, modulo minor comments/questions.

https://codereview.chromium.org/1978573003/diff/100001/tools/viewer/Viewer.cpp
File tools/viewer/Viewer.cpp (right):

https://codereview.chromium.org/1978573003/diff/100001/tools/viewer/Viewer.cp...
tools/viewer/Viewer.cpp:119: // TODO: get Vulkan -> OpenGL working without
swapchain creation failure
This is unfortunate. Is it likely that we can fix whatever is wrong?

https://codereview.chromium.org/1978573003/diff/100001/tools/viewer/sk_app/GL...
File tools/viewer/sk_app/GLWindowContext.cpp (right):

https://codereview.chromium.org/1978573003/diff/100001/tools/viewer/sk_app/GL...
tools/viewer/sk_app/GLWindowContext.cpp:70: // TODO: Query the actual
framebuffer for sRGB capable. However, to
This entire comment belongs up around line 44 now (where fPixelConfig is being
determined).

https://codereview.chromium.org/1978573003/diff/100001/tools/viewer/sk_app/Wi...
File tools/viewer/sk_app/Window.h (right):

https://codereview.chromium.org/1978573003/diff/100001/tools/viewer/sk_app/Wi...
tools/viewer/sk_app/Window.h:42: kBackendTypeCount = kLast_BackendType + 1
Is this used anywhere?

[jvanverth1, 2016-05-17 17:59:50]

https://codereview.chromium.org/1978573003/diff/100001/tools/viewer/Viewer.cpp
File tools/viewer/Viewer.cpp (right):

https://codereview.chromium.org/1978573003/diff/100001/tools/viewer/Viewer.cp...
tools/viewer/Viewer.cpp:119: // TODO: get Vulkan -> OpenGL working without
swapchain creation failure
On 2016/05/17 17:32:11, Brian Osman wrote:
> This is unfortunate. Is it likely that we can fix whatever is wrong?

I don't know. I put a message out to vulkan-devs and no one has responded. I'm
wondering if it's possible on Linux.

https://codereview.chromium.org/1978573003/diff/100001/tools/viewer/sk_app/GL...
File tools/viewer/sk_app/GLWindowContext.cpp (right):

https://codereview.chromium.org/1978573003/diff/100001/tools/viewer/sk_app/GL...
tools/viewer/sk_app/GLWindowContext.cpp:70: // TODO: Query the actual
framebuffer for sRGB capable. However, to
On 2016/05/17 17:32:11, Brian Osman wrote:
> This entire comment belongs up around line 44 now (where fPixelConfig is being
> determined).

Done.

https://codereview.chromium.org/1978573003/diff/100001/tools/viewer/sk_app/Wi...
File tools/viewer/sk_app/Window.h (right):

https://codereview.chromium.org/1978573003/diff/100001/tools/viewer/sk_app/Wi...
tools/viewer/sk_app/Window.h:42: kBackendTypeCount = kLast_BackendType + 1
On 2016/05/17 17:32:11, Brian Osman wrote:
> Is this used anywhere?

It's used for the array of strings in Viewer.cpp.

[jvanverth1, 2016-05-17 18:55:56]

The CQ bit was checked by jvanverth@google.com

[jvanverth1, 2016-05-17 18:55:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
brianosman@google.com
Link to the patchset: https://codereview.chromium.org/1978573003/#ps120001
(title: "Move comment")

[commit-bot: I haz the power, 2016-05-17 18:56:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1978573003/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1978573003/120001

[commit-bot: I haz the power, 2016-05-17 19:15:51]

Description was changed from

==========
Add OpenGL context to Viewer.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Add OpenGL context to Viewer.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/56a11e4d6f3d436a3c2497c9c9e71a117d78a93f
==========

[commit-bot: I haz the power, 2016-05-17 19:15:53]

Committed patchset #7 (id:120001) as
https://skia.googlesource.com/skia/+/56a11e4d6f3d436a3c2497c9c9e71a117d78a93f

[jvanverth1, 2016-05-18 14:01:04]

A revert of this CL (patchset #7 id:120001) has been created in
https://codereview.chromium.org/1990893002/ by jvanverth@google.com.

The reason for reverting is: sk_app/WindowContext.cpp is missing. Need to add
file and resubmit..

[jvanverth1, 2016-05-20 12:36:39]

Description was changed from

==========
Add OpenGL context to Viewer.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/56a11e4d6f3d436a3c2497c9c9e71a117d78a93f
==========

to

==========
Add OpenGL context to Viewer.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/56a11e4d6f3d436a3c2497c9c9e71a117d78a93f
==========

[jvanverth1, 2016-05-20 12:44:07]

The CQ bit was checked by jvanverth@google.com

[jvanverth1, 2016-05-20 12:44:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
brianosman@google.com
Link to the patchset: https://codereview.chromium.org/1978573003/#ps160001
(title: "Rebase to ToT")

[commit-bot: I haz the power, 2016-05-20 12:44:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1978573003/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1978573003/160001

[commit-bot: I haz the power, 2016-05-20 13:01:09]

Description was changed from

==========
Add OpenGL context to Viewer.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/56a11e4d6f3d436a3c2497c9c9e71a117d78a93f
==========

to

==========
Add OpenGL context to Viewer.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/56a11e4d6f3d436a3c2497c9c9e71a117d78a93f

Committed:
https://skia.googlesource.com/skia/+/af236b5aa9e7d71d59bee6533d16deb76e9d098b
==========

[commit-bot: I haz the power, 2016-05-20 13:01:11]

Committed patchset #9 (id:160001) as
https://skia.googlesource.com/skia/+/af236b5aa9e7d71d59bee6533d16deb76e9d098b