Replace some calls to Release() with direct delete, part 1.

Replace some calls to Release() with direct delete, part 1.

Searching for the anti-pattern:
  void Release() { delete this; }

We must be explicit on the ownership model.
Add unique_ptrs as a result.

Committed: https://pdfium.googlesource.com/pdfium/+/f74ad998d2e8d2636fb25e94823946a3b151e34e

[Tom Sepez, 2016-05-06 17:39:49]

Description was changed from

==========
Replace some calls to Release() with direct delete, part 1.

Searching for the anti-pattern:
  void Release() { delete this; }

No release for you! There can be no pussyfooting on the
ownership model.
==========

to

==========
Replace some calls to Release() with direct delete, part 1.

Searching for the anti-pattern:
  void Release() { delete this; }

We must be explicit on the ownership model.
==========

[Tom Sepez, 2016-05-06 21:34:58]

Description was changed from

==========
Replace some calls to Release() with direct delete, part 1.

Searching for the anti-pattern:
  void Release() { delete this; }

We must be explicit on the ownership model.
==========

to

==========
Replace some calls to Release() with direct delete, part 1.

Searching for the anti-pattern:
  void Release() { delete this; }

We must be explicit on the ownership model.
Add unique_ptrs as a result.
==========

[Tom Sepez, 2016-05-06 21:41:13]

tsepez@chromium.org changed reviewers:
+ weili@google.com

[Tom Sepez, 2016-05-06 21:41:14]

Wei, for review.  Thanks.

https://codereview.chromium.org/1960673003/diff/140001/xfa/fde/css/fde_csssty...
File xfa/fde/css/fde_cssstyleselector.cpp (left):

https://codereview.chromium.org/1960673003/diff/140001/xfa/fde/css/fde_csssty...
xfa/fde/css/fde_cssstyleselector.cpp:544: int32_t iLen;
note: these two are shadows, rename.

[Wei Li, 2016-05-06 22:01:20]

weili@chromium.org changed reviewers:
+ weili@chromium.org

[Wei Li, 2016-05-06 22:01:21]

lgtm

https://codereview.chromium.org/1960673003/diff/140001/xfa/fde/tto/fde_textou...
File xfa/fde/tto/fde_textout.cpp (right):

https://codereview.chromium.org/1960673003/diff/140001/xfa/fde/tto/fde_textou...
xfa/fde/tto/fde_textout.cpp:909: delete pPath;
Nit: why not use unique_ptr for pPath as well?

https://codereview.chromium.org/1960673003/diff/140001/xfa/fxfa/app/xfa_ffwid...
File xfa/fxfa/app/xfa_ffwidgetacc.cpp (right):

https://codereview.chromium.org/1960673003/diff/140001/xfa/fxfa/app/xfa_ffwid...
xfa/fxfa/app/xfa_ffwidgetacc.cpp:747:
static_cast<CXFA_FieldLayoutData*>(m_pLayoutData)->m_pCapTextLayout.get();
Is the cast needed? Ditto for all below.

[Tom Sepez, 2016-05-11 17:05:39]

https://codereview.chromium.org/1960673003/diff/140001/xfa/fde/tto/fde_textou...
File xfa/fde/tto/fde_textout.cpp (right):

https://codereview.chromium.org/1960673003/diff/140001/xfa/fde/tto/fde_textou...
xfa/fde/tto/fde_textout.cpp:909: delete pPath;
On 2016/05/06 22:01:21, Wei Li wrote:
> Nit: why not use unique_ptr for pPath as well?

Done.

https://codereview.chromium.org/1960673003/diff/140001/xfa/fxfa/app/xfa_ffwid...
File xfa/fxfa/app/xfa_ffwidgetacc.cpp (right):

https://codereview.chromium.org/1960673003/diff/140001/xfa/fxfa/app/xfa_ffwid...
xfa/fxfa/app/xfa_ffwidgetacc.cpp:747:
static_cast<CXFA_FieldLayoutData*>(m_pLayoutData)->m_pCapTextLayout.get();
On 2016/05/06 22:01:21, Wei Li wrote:
> Is the cast needed? Ditto for all below.
Yes, otherwise error: no member named 'm_pCapTextLayout' in
'CXFA_WidgetLayoutData' so we need to explicitly sub-class it.

[Tom Sepez, 2016-05-11 17:13:27]

The CQ bit was checked by tsepez@chromium.org

[Tom Sepez, 2016-05-11 17:13:28]

The patchset sent to the CQ was uploaded after l-g-t-m from weili@chromium.org
Link to the patchset: https://codereview.chromium.org/1960673003/#ps180001
(title: "Another unique_ptr.")

[commit-bot: I haz the power, 2016-05-11 17:13:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1960673003/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1960673003/180001

[commit-bot: I haz the power, 2016-05-11 17:26:09]

Description was changed from

==========
Replace some calls to Release() with direct delete, part 1.

Searching for the anti-pattern:
  void Release() { delete this; }

We must be explicit on the ownership model.
Add unique_ptrs as a result.
==========

to

==========
Replace some calls to Release() with direct delete, part 1.

Searching for the anti-pattern:
  void Release() { delete this; }

We must be explicit on the ownership model.
Add unique_ptrs as a result.

Committed:
https://pdfium.googlesource.com/pdfium/+/f74ad998d2e8d2636fb25e94823946a3b151...
==========

[commit-bot: I haz the power, 2016-05-11 17:26:10]

Committed patchset #10 (id:180001) as
https://pdfium.googlesource.com/pdfium/+/f74ad998d2e8d2636fb25e94823946a3b151...