xfa/fxfa/app/xfa_fwltheme.h - Issue 1960673003: Replace some calls to Release() with direct delete, part 1.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fxfa/app/xfa_fwltheme.h

Issue 1960673003: Replace some calls to Release() with direct delete, part 1. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Another unique_ptr. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: xfa/fxfa/app/xfa_fwltheme.h

diff --git a/xfa/fxfa/app/xfa_fwltheme.h b/xfa/fxfa/app/xfa_fwltheme.h

index 7d58b43c9b3420b504b588c659570ad60fc46e08..319df8dfa564b450a0842b3844df02d7a1e50dc9 100644

--- a/xfa/fxfa/app/xfa_fwltheme.h

+++ b/xfa/fxfa/app/xfa_fwltheme.h

@@ -7,6 +7,8 @@

#ifndef XFA_FXFA_APP_XFA_FWLTHEME_H_

#define XFA_FXFA_APP_XFA_FWLTHEME_H_

+#include <memory>

#include "xfa/fwl/core/ifwl_themeprovider.h"

#include "xfa/fwl/theme/cfwl_barcodetp.h"

#include "xfa/fwl/theme/cfwl_carettp.h"

@@ -77,7 +79,7 @@ class CXFA_FWLTheme : public IFWL_ThemeProvider {

CFWL_PushButtonTP* m_pPushButtonTP;

CFWL_CaretTP* m_pCaretTP;

CFWL_BarcodeTP* m_pBarcodeTP;

- CFDE_TextOut* m_pTextOut;

+ std::unique_ptr<CFDE_TextOut> m_pTextOut;

FX_FLOAT m_fCapacity;

uint32_t m_dwCapacity;

IFX_Font* m_pCalendarFont;

« no previous file with comments | « xfa/fxfa/app/xfa_ffwidgetacc.cpp ('k') | xfa/fxfa/app/xfa_fwltheme.cpp » ('j') | no next file with comments »