Replace some calls to Release() with direct delete, part 1.

xfa/fwl/theme/cfwl_widgettp.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "xfa/fwl/theme/cfwl_widgettp.h"
 
 #include <algorithm>
 
@@ skipping 65 matching lines @@
 }
 FWL_Error CFWL_WidgetTP::SetThemeMatrix(IFWL_Widget* pWidget,
                                         const CFX_Matrix& matrix) {
   _ctm.Set(matrix.a, matrix.b, matrix.c, matrix.d, matrix.e, matrix.f);
   return FWL_Error::Succeeded;
 }
 FX_BOOL CFWL_WidgetTP::DrawBackground(CFWL_ThemeBackground* pParams) {
   return TRUE;
 }
 FX_BOOL CFWL_WidgetTP::DrawText(CFWL_ThemeText* pParams) {
-  if (!m_pTextOut) {
+  if (!m_pTextOut)
     InitTTO();
-  }
+
   int32_t iLen = pParams->m_wsText.GetLength();
   if (iLen <= 0)
     return FALSE;
   CFX_Graphics* pGraphics = pParams->m_pGraphics;
   m_pTextOut->SetRenderDevice(pGraphics->GetRenderDevice());
   m_pTextOut->SetStyles(pParams->m_dwTTOStyles);
   m_pTextOut->SetAlignment(pParams->m_iTTOAlign);
   CFX_Matrix* pMatrix = &pParams->m_matrix;
   pMatrix->Concat(*pGraphics->GetMatrix());
   m_pTextOut->SetMatrix(*pMatrix);
@@ skipping 77 matching lines @@
   m_pTextOut->CalcLogicSize(pParams->m_wsText.c_str(),
                             pParams->m_wsText.GetLength(), rect);
   return TRUE;
 }
 FWL_Error CFWL_WidgetTP::Initialize() {
   m_dwThemeID = 0;
   _ctm.SetIdentity();
   return FWL_Error::Succeeded;
 }
 FWL_Error CFWL_WidgetTP::Finalize() {
-  if (!m_pTextOut) {
+  if (!m_pTextOut)
     FinalizeTTO();
-  }
   return FWL_Error::Succeeded;
 }
 CFWL_WidgetTP::~CFWL_WidgetTP() {}
 FWL_Error CFWL_WidgetTP::SetFont(IFWL_Widget* pWidget,
                                  const FX_WCHAR* strFont,
                                  FX_FLOAT fFontSize,
                                  FX_ARGB rgbFont) {
-  if (!m_pTextOut) {
+  if (!m_pTextOut)
     return FWL_Error::Succeeded;
-  }
+
   m_pFDEFont = CFWL_FontManager::GetInstance()->FindFont(strFont, 0, 0);
   m_pTextOut->SetFont(m_pFDEFont);
   m_pTextOut->SetFontSize(fFontSize);
   m_pTextOut->SetTextColor(rgbFont);
   return FWL_Error::Succeeded;
 }
 FWL_Error CFWL_WidgetTP::SetFont(IFWL_Widget* pWidget,
                                  IFX_Font* pFont,
                                  FX_FLOAT fFontSize,
                                  FX_ARGB rgbFont) {
-  if (!m_pTextOut) {
+  if (!m_pTextOut)
     return FWL_Error::Succeeded;
-  }
+
   m_pTextOut->SetFont(pFont);
   m_pTextOut->SetFontSize(fFontSize);
   m_pTextOut->SetTextColor(rgbFont);
   return FWL_Error::Succeeded;
 }
 IFX_Font* CFWL_WidgetTP::GetFont(IFWL_Widget* pWidget) {
   return m_pFDEFont;
 }
+
 CFWL_WidgetTP::CFWL_WidgetTP()
-    : m_dwRefCount(1), m_pTextOut(NULL), m_pFDEFont(NULL), m_dwThemeID(0) {}
+    : m_dwRefCount(1), m_pFDEFont(nullptr), m_dwThemeID(0) {}
+
 FWL_Error CFWL_WidgetTP::InitTTO() {
-  if (m_pTextOut) {
+  if (m_pTextOut)
     return FWL_Error::Succeeded;
-  }
+
   m_pFDEFont =
       CFWL_FontManager::GetInstance()->FindFont(FX_WSTRC(L"Helvetica"), 0, 0);
-  m_pTextOut = new CFDE_TextOut;
+  m_pTextOut.reset(new CFDE_TextOut);
   m_pTextOut->SetFont(m_pFDEFont);
   m_pTextOut->SetFontSize(FWLTHEME_CAPACITY_FontSize);
   m_pTextOut->SetTextColor(FWLTHEME_CAPACITY_TextColor);
   m_pTextOut->SetEllipsisString(L"...");
   return FWL_Error::Succeeded;
 }
+
 FWL_Error CFWL_WidgetTP::FinalizeTTO() {
-  if (m_pTextOut) {
-    m_pTextOut->Release();
-    m_pTextOut = NULL;
-  }
+  m_pTextOut.reset();
   return FWL_Error::Succeeded;
 }
 
 void CFWL_WidgetTP::DrawEdge(CFX_Graphics* pGraphics,
                              uint32_t dwStyles,
                              const CFX_RectF* pRect,
                              CFX_Matrix* pMatrix) {
   if (!pGraphics)
     return;
   if (!pRect)
@@ skipping 561 matching lines @@
     m_pColorData->clrEnd[0] = ArgbEncode(255, 175, 204, 251);
     m_pColorData->clrEnd[1] = ArgbEncode(255, 185, 218, 251);
     m_pColorData->clrEnd[2] = ArgbEncode(255, 210, 222, 235);
     m_pColorData->clrEnd[3] = ArgbEncode(255, 243, 241, 236);
     m_pColorData->clrSign[0] = ArgbEncode(255, 77, 97, 133);
     m_pColorData->clrSign[1] = ArgbEncode(255, 77, 97, 133);
     m_pColorData->clrSign[2] = ArgbEncode(255, 77, 97, 133);
     m_pColorData->clrSign[3] = ArgbEncode(255, 128, 128, 128);
   }
 }