xfa/fde/fde_iterator.h - Issue 1960673003: Replace some calls to Release() with direct delete, part 1.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fde/fde_iterator.h

Issue 1960673003: Replace some calls to Release() with direct delete, part 1. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Another unique_ptr. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: xfa/fde/fde_iterator.h

diff --git a/xfa/fde/fde_iterator.h b/xfa/fde/fde_iterator.h

index 4d089254ea771a0fb1864ebd44f5427b6d781848..4f3fdf3f297c083e7ad99501eb9e9fcaf5ade4d8 100644

--- a/xfa/fde/fde_iterator.h

+++ b/xfa/fde/fde_iterator.h

@@ -20,9 +20,7 @@ struct FDE_CANVASITEM {

class CFDE_VisualSetIterator : public CFX_Target {

public:

CFDE_VisualSetIterator();

- ~CFDE_VisualSetIterator();

- void Release() { delete this; }

+ ~CFDE_VisualSetIterator() override;

FX_BOOL AttachCanvas(IFDE_CanvasSet* pCanvas);

FX_BOOL FilterObjects(uint32_t dwObjects = 0xFFFFFFFF);

« no previous file with comments | « xfa/fde/fde_gedevice.h ('k') | xfa/fde/fde_render.h » ('j') | no next file with comments »