xfa/fwl/theme/cfwl_widgettp.h - Issue 1960673003: Replace some calls to Release() with direct delete, part 1.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fwl/theme/cfwl_widgettp.h

Issue 1960673003: Replace some calls to Release() with direct delete, part 1. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Another unique_ptr. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: xfa/fwl/theme/cfwl_widgettp.h

diff --git a/xfa/fwl/theme/cfwl_widgettp.h b/xfa/fwl/theme/cfwl_widgettp.h

index edb793def99904fc49d5138a28a6ad29b75dd240..b66e19344e11541375019060c30f1cb6f3b5712f 100644

--- a/xfa/fwl/theme/cfwl_widgettp.h

+++ b/xfa/fwl/theme/cfwl_widgettp.h

@@ -220,7 +220,7 @@ class CFWL_WidgetTP {

FWLTHEME_STATE eState,

CFX_Matrix* pMatrix = NULL);

uint32_t m_dwRefCount;

- CFDE_TextOut* m_pTextOut;

+ std::unique_ptr<CFDE_TextOut> m_pTextOut;

IFX_Font* m_pFDEFont;

FX_FLOAT m_fValue;

uint32_t m_dwValue;

« no previous file with comments | « xfa/fwl/basewidget/fwl_editimp.cpp ('k') | xfa/fwl/theme/cfwl_widgettp.cpp » ('j') | no next file with comments »