Replace some calls to Release() with direct delete, part 1.

xfa/fxfa/app/xfa_fwltheme.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "xfa/fxfa/app/xfa_fwltheme.h"
 
 #include "xfa/fde/tto/fde_textout.h"
 #include "xfa/fgas/crt/fgas_codepage.h"
@@ skipping 26 matching lines @@
   IFWL_Widget* pOuter = pWidget;
   while (pOuter->GetOuter()) {
     pOuter = pOuter->GetOuter();
   }
   if (pOuter) {
     return (CXFA_FFWidget*)pOuter->GetPrivateData(pOuter);
   }
   return NULL;
 }
 CXFA_FWLTheme::CXFA_FWLTheme(CXFA_FFApp* pApp) : m_pApp(pApp) {
-  m_pTextOut = NULL;
   m_dwCapacity = 0;
   m_fCapacity = 0;
   m_pCalendarFont = NULL;
   m_Rect.Set(0, 0, 0, 0);
   m_pCheckBoxTP = new CXFA_FWLCheckBoxTP;
   m_pListBoxTP = new CFWL_ListBoxTP;
   m_pPictureBoxTP = new CFWL_PictureBoxTP;
   m_pSrollBarTP = new CFWL_ScrollBarTP;
   m_pEditTP = new CXFA_FWLEditTP;
   m_pComboBoxTP = new CFWL_ComboBoxTP;
@@ skipping 12 matching lines @@
   delete m_pSrollBarTP;
   delete m_pEditTP;
   delete m_pComboBoxTP;
   delete m_pMonthCalendarTP;
   delete m_pDateTimePickerTP;
   delete m_pPushButtonTP;
   delete m_pCaretTP;
   delete m_pBarcodeTP;
 }
 FWL_Error CXFA_FWLTheme::Initialize() {
-  m_pTextOut = new CFDE_TextOut;
+  m_pTextOut.reset(new CFDE_TextOut);
   for (size_t i = 0; !m_pCalendarFont && i < FX_ArraySize(g_FWLTheme_CalFonts);
        ++i) {
     m_pCalendarFont = IFX_Font::LoadFont(g_FWLTheme_CalFonts[i], 0, 0,
                                          m_pApp->GetFDEFontMgr());
   }
   if (!m_pCalendarFont) {
 #if _FXM_PLATFORM_ == _FXM_PLATFORM_WINDOWS_
     m_pCalendarFont = m_pApp->GetFDEFontMgr()->GetDefFontByCodePage(
         FX_CODEPAGE_MSWin_WesternEuropean, 0, NULL);
 #else
     m_pCalendarFont = m_pApp->GetFDEFontMgr()->GetFontByCodePage(
         FX_CODEPAGE_MSWin_WesternEuropean, 0, NULL);
 #endif
   }
 
   ASSERT(NULL != m_pCalendarFont);
   FWLTHEME_Init();
   return FWL_Error::Succeeded;
 }
 FWL_Error CXFA_FWLTheme::Finalize() {
-  if (m_pTextOut) {
-    m_pTextOut->Release();
-    m_pTextOut = NULL;
-  }
+  m_pTextOut.reset();
   if (m_pCalendarFont) {
     m_pCalendarFont->Release();
-    m_pCalendarFont = NULL;
+    m_pCalendarFont = nullptr;
   }
   FWLTHEME_Release();
   return FWL_Error::Succeeded;
 }
 
 bool CXFA_FWLTheme::IsValidWidget(IFWL_Widget* pWidget) {
   return TRUE;
 }
 
 uint32_t CXFA_FWLTheme::GetThemeID(IFWL_Widget* pWidget) {
@@ skipping 261 matching lines @@
   CXFA_FFWidget* pWidget = XFA_ThemeGetOuterWidget(pParams->m_pWidget);
   if (!pWidget)
     return FALSE;
 
   CXFA_WidgetAcc* pAcc = pWidget->GetDataAcc();
   m_pTextOut->SetFont(pAcc->GetFDEFont());
   m_pTextOut->SetFontSize(pAcc->GetFontSize());
   m_pTextOut->SetTextColor(pAcc->GetTextColor());
   if (!pParams)
     return FALSE;
-  if (!m_pTextOut)
-    return FALSE;
   m_pTextOut->SetAlignment(pParams->m_iTTOAlign);
   m_pTextOut->SetStyles(pParams->m_dwTTOStyles);
   m_pTextOut->CalcLogicSize(pParams->m_wsText.c_str(),
                             pParams->m_wsText.GetLength(), rect);
   return TRUE;
 }
 CFWL_WidgetTP* CXFA_FWLTheme::GetTheme(IFWL_Widget* pWidget) {
   switch (pWidget->GetClassID()) {
     case FWL_Type::CheckBox:
       return m_pCheckBoxTP;
@@ skipping 85 matching lines @@
       }
     }
     CFX_Color crLine(cr);
     pParams->m_pGraphics->SetStrokeColor(&crLine);
     pParams->m_pGraphics->SetLineWidth(fWidth);
     pParams->m_pGraphics->StrokePath(pParams->m_pPath, &pParams->m_matrix);
     return TRUE;
   }
   return CFWL_EditTP::DrawBackground(pParams);
 }