xfa/fde/css/fde_cssstyleselector.h - Issue 1960673003: Replace some calls to Release() with direct delete, part 1.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fde/css/fde_cssstyleselector.h

Issue 1960673003: Replace some calls to Release() with direct delete, part 1. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Another unique_ptr. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: xfa/fde/css/fde_cssstyleselector.h

diff --git a/xfa/fde/css/fde_cssstyleselector.h b/xfa/fde/css/fde_cssstyleselector.h

index 790149c596e2882b0e36fd9d9c28010f84369e31..cb54aaed7fbb78e892d8bdfd0ccacf879cd6c2a7 100644

--- a/xfa/fde/css/fde_cssstyleselector.h

+++ b/xfa/fde/css/fde_cssstyleselector.h

@@ -93,9 +93,7 @@ class CFDE_CSSRuleCollection : public CFX_Target {

class CFDE_CSSStyleSelector : public CFX_Target {

public:

CFDE_CSSStyleSelector();

- ~CFDE_CSSStyleSelector();

- void Release() { delete this; }

+ ~CFDE_CSSStyleSelector() override;

void SetFontMgr(IFX_FontMgr* pFontMgr);

void SetDefFontSize(FX_FLOAT fFontSize);

« no previous file with comments | « xfa/fde/cfde_path.h ('k') | xfa/fde/css/fde_cssstyleselector.cpp » ('j') | no next file with comments »