core/fxcodec/codec/fx_codec_jpeg.cpp - Issue 1960673003: Replace some calls to Release() with direct delete, part 1.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fxcodec/codec/fx_codec_jpeg.cpp

Issue 1960673003: Replace some calls to Release() with direct delete, part 1. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Another unique_ptr. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: core/fxcodec/codec/fx_codec_jpeg.cpp

diff --git a/core/fxcodec/codec/fx_codec_jpeg.cpp b/core/fxcodec/codec/fx_codec_jpeg.cpp

index ebe6106945178adf40eeab3185e76f2351ec7f26..c41dde943f040e9ad866dfa4950e70b9845c00f3 100644

--- a/core/fxcodec/codec/fx_codec_jpeg.cpp

+++ b/core/fxcodec/codec/fx_codec_jpeg.cpp

@@ -318,7 +318,6 @@ class CCodec_JpegDecoder : public CCodec_ScanlineDecoder {

int height,

int nComps,

FX_BOOL ColorTransform);

- void Destroy() { delete this; }

// CCodec_ScanlineDecoder

FX_BOOL v_Rewind() override;

« no previous file with comments | « core/fxcodec/codec/fx_codec_flate.cpp ('k') | xfa/fde/cfde_path.h » ('j') | no next file with comments »