Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1956703005: EDK: Check that handle rights are preserved in various tests. (Closed)

Created:
4 years, 7 months ago by viettrungluu
Modified:
4 years, 7 months ago
Reviewers:
vardhan, azani
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@work787_edk_handle_13.8
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

EDK: Check that handle rights are preserved in various tests. R=azani@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/0c4736766ea2484261115a781146ab4fba4af4d6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -12 lines) Patch
M mojo/edk/system/data_pipe_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/multiprocess_message_pipe_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M mojo/edk/system/remote_data_pipe_impl_unittest.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M mojo/edk/system/remote_message_pipe_unittest.cc View 6 chunks +12 lines, -6 lines 0 comments Download

Depends on Patchset:

Issue 1956843002 Patch 1

Dependent Patchsets:

Issue 1953293003 Patch 1

Messages

Total messages: 7 (3 generated)
viettrungluu
Depends on https://codereview.chromium.org/1956843002/.
4 years, 7 months ago (2016-05-06 17:51:58 UTC) #1
viettrungluu
+azani, if he's around
4 years, 7 months ago (2016-05-09 17:37:06 UTC) #3
azani
lgtm
4 years, 7 months ago (2016-05-09 21:46:21 UTC) #4
viettrungluu
4 years, 7 months ago (2016-05-09 23:09:34 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
0c4736766ea2484261115a781146ab4fba4af4d6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698