Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 1956843002: EDK: Make TransportData preserve handle rights. (Closed)

Created:
4 years, 7 months ago by viettrungluu
Modified:
4 years, 7 months ago
Reviewers:
vardhan, azani
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

EDK: Make TransportData preserve handle rights. Now, at least theoretically, handle rights should be preserved when sent over a message pipe (including across processes). (I'll add/update tests separately.) R=azani@chromium.org, vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/2c145bfc0ff543c5a79d973aac78831f87424ab1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -62 lines) Patch
M mojo/edk/system/channel.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/message_in_transit.h View 2 chunks +0 lines, -3 lines 0 comments Download
M mojo/edk/system/message_in_transit.cc View 2 chunks +1 line, -13 lines 0 comments Download
M mojo/edk/system/message_pipe_endpoint.h View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/edk/system/message_pipe_test_utils.h View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/edk/system/transport_data.h View 4 chunks +5 lines, -6 lines 0 comments Download
M mojo/edk/system/transport_data.cc View 9 chunks +17 lines, -39 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 7 (3 generated)
viettrungluu
4 years, 7 months ago (2016-05-06 17:32:04 UTC) #1
viettrungluu
+azani, if he's around
4 years, 7 months ago (2016-05-09 17:36:27 UTC) #4
azani
lgtm
4 years, 7 months ago (2016-05-09 21:45:47 UTC) #5
viettrungluu
4 years, 7 months ago (2016-05-09 23:06:46 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2c145bfc0ff543c5a79d973aac78831f87424ab1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698