Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: mojo/edk/system/data_pipe_impl_unittest.cc

Issue 1956703005: EDK: Check that handle rights are preserved in various tests. (Closed) Base URL: https://github.com/domokit/mojo.git@work787_edk_handle_13.8
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | mojo/edk/system/multiprocess_message_pipe_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/edk/system/data_pipe_impl_unittest.cc
diff --git a/mojo/edk/system/data_pipe_impl_unittest.cc b/mojo/edk/system/data_pipe_impl_unittest.cc
index c50e6499e0341dc6b55ff3197403781444f281ca..53b0ad55dadb5433ce2b0c547ce98f9dd0fed73b 100644
--- a/mojo/edk/system/data_pipe_impl_unittest.cc
+++ b/mojo/edk/system/data_pipe_impl_unittest.cc
@@ -316,7 +316,7 @@ class RemoteDataPipeImplTestHelper : public DataPipeImplTestHelper {
ASSERT_EQ(1u, read_num_handles);
ASSERT_TRUE(read_handles[0]);
EXPECT_TRUE(read_handles[0].dispatcher->HasOneRef());
- // TODO(vtl): Also check the rights here once they're actually preserved?
+ EXPECT_EQ(handle_to_send.rights, read_handles[0].rights);
*handle_to_receive = std::move(read_handles[0]);
}
« no previous file with comments | « no previous file | mojo/edk/system/multiprocess_message_pipe_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698