Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1953293003: EDK: Add handle rights checking to the various entrypoints. (Closed)

Created:
4 years, 7 months ago by viettrungluu
Modified:
4 years, 7 months ago
Reviewers:
vardhan, azani
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@work788_edk_handle_13.9-x-work787_edk_handle_13.8
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

EDK: Add handle rights checking to the various entrypoints. To do (separately): * Figure out how to deal with rights for buffers. * Update comments/documentation in //mojo/public/c/system. R=azani@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/5fdaf5e36b7633d353bab59e90c413a9238d9882

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -41 lines) Patch
M mojo/edk/system/core.h View 2 chunks +30 lines, -5 lines 0 comments Download
M mojo/edk/system/core.cc View 17 chunks +94 lines, -31 lines 0 comments Download
M mojo/edk/system/data_pipe_consumer_dispatcher.cc View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/edk/system/entrypoint_class.h View 1 chunk +4 lines, -0 lines 0 comments Download
M mojo/edk/system/message_pipe_dispatcher.cc View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/edk/system/message_pipe_dispatcher_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/edk/system/mock_simple_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/platform_handle_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/platform_handle_dispatcher_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/edk/system/shared_buffer_dispatcher.cc View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/edk/system/shared_buffer_dispatcher_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Issue 1956703005 Patch 1

Dependent Patchsets:

Issue 1957713003 Patch 1

Messages

Total messages: 8 (3 generated)
viettrungluu
Depends on https://codereview.chromium.org/1956703005/.
4 years, 7 months ago (2016-05-06 18:31:12 UTC) #1
viettrungluu
+azani, if he's around
4 years, 7 months ago (2016-05-09 17:37:19 UTC) #2
viettrungluu
+azani (for realz this time), if he's around
4 years, 7 months ago (2016-05-09 17:37:50 UTC) #4
azani
lgtm
4 years, 7 months ago (2016-05-09 21:49:25 UTC) #5
viettrungluu
4 years, 7 months ago (2016-05-09 23:10:18 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
5fdaf5e36b7633d353bab59e90c413a9238d9882 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698