Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(774)

Unified Diff: mojo/edk/system/remote_data_pipe_impl_unittest.cc

Issue 1956703005: EDK: Check that handle rights are preserved in various tests. (Closed) Base URL: https://github.com/domokit/mojo.git@work787_edk_handle_13.8
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/edk/system/remote_data_pipe_impl_unittest.cc
diff --git a/mojo/edk/system/remote_data_pipe_impl_unittest.cc b/mojo/edk/system/remote_data_pipe_impl_unittest.cc
index 24df824482d16580f05fc6fbc34c0ff750a42403..86c54ce171e24d5a438275dbe8c443d99910ee25 100644
--- a/mojo/edk/system/remote_data_pipe_impl_unittest.cc
+++ b/mojo/edk/system/remote_data_pipe_impl_unittest.cc
@@ -234,7 +234,8 @@ TEST_F(RemoteDataPipeImplTest, SendConsumerWithClosedProducer) {
EXPECT_EQ(Dispatcher::Type::DATA_PIPE_CONSUMER,
read_handles[0].dispatcher->GetType());
- // TODO(vtl): Also check the rights here once they're actually preserved?
+ EXPECT_EQ(DataPipeConsumerDispatcher::kDefaultHandleRights,
+ read_handles[0].rights);
consumer = RefPtr<DataPipeConsumerDispatcher>(
static_cast<DataPipeConsumerDispatcher*>(
read_handles[0].dispatcher.get()));
@@ -356,7 +357,8 @@ TEST_F(RemoteDataPipeImplTest, SendConsumerDuringTwoPhaseWrite) {
EXPECT_EQ(Dispatcher::Type::DATA_PIPE_CONSUMER,
read_handles[0].dispatcher->GetType());
- // TODO(vtl): Also check the rights here once they're actually preserved?
+ EXPECT_EQ(DataPipeConsumerDispatcher::kDefaultHandleRights,
+ read_handles[0].rights);
consumer = RefPtr<DataPipeConsumerDispatcher>(
static_cast<DataPipeConsumerDispatcher*>(
read_handles[0].dispatcher.get()));
@@ -482,7 +484,8 @@ TEST_F(RemoteDataPipeImplTest, SendConsumerDuringSecondTwoPhaseWrite) {
EXPECT_EQ(Dispatcher::Type::DATA_PIPE_CONSUMER,
read_handles[0].dispatcher->GetType());
- // TODO(vtl): Also check the rights here once they're actually preserved?
+ EXPECT_EQ(DataPipeConsumerDispatcher::kDefaultHandleRights,
+ read_handles[0].rights);
consumer = RefPtr<DataPipeConsumerDispatcher>(
static_cast<DataPipeConsumerDispatcher*>(
read_handles[0].dispatcher.get()));
« no previous file with comments | « mojo/edk/system/multiprocess_message_pipe_unittest.cc ('k') | mojo/edk/system/remote_message_pipe_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698