Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1038)

Unified Diff: mojo/edk/system/multiprocess_message_pipe_unittest.cc

Issue 1956703005: EDK: Check that handle rights are preserved in various tests. (Closed) Base URL: https://github.com/domokit/mojo.git@work787_edk_handle_13.8
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/edk/system/data_pipe_impl_unittest.cc ('k') | mojo/edk/system/remote_data_pipe_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/edk/system/multiprocess_message_pipe_unittest.cc
diff --git a/mojo/edk/system/multiprocess_message_pipe_unittest.cc b/mojo/edk/system/multiprocess_message_pipe_unittest.cc
index 3efa58f9052945f4d1d8bfb18183129f2f705fff..6d5c57cf25498c9576f177ed29947d731d890f56 100644
--- a/mojo/edk/system/multiprocess_message_pipe_unittest.cc
+++ b/mojo/edk/system/multiprocess_message_pipe_unittest.cc
@@ -249,7 +249,7 @@ MOJO_MULTIPROCESS_TEST_CHILD_MAIN(CheckSharedBuffer) {
CHECK_EQ(num_handles, 1u);
CHECK_EQ(handles[0].dispatcher->GetType(), Dispatcher::Type::SHARED_BUFFER);
- // TODO(vtl): Also check the rights here once they're actually preserved?
+ CHECK_EQ(handles[0].rights, SharedBufferDispatcher::kDefaultHandleRights);
RefPtr<SharedBufferDispatcher> dispatcher(
static_cast<SharedBufferDispatcher*>(handles[0].dispatcher.get()));
@@ -437,7 +437,8 @@ MOJO_MULTIPROCESS_TEST_CHILD_MAIN(CheckPlatformHandleFile) {
for (size_t i = 0; i < num_read_handles; ++i) {
CHECK_EQ(read_handles[i].dispatcher->GetType(),
Dispatcher::Type::PLATFORM_HANDLE);
- // TODO(vtl): Also check the rights here once they're actually preserved?
+ CHECK_EQ(read_handles[i].rights,
+ PlatformHandleDispatcher::kDefaultHandleRights);
RefPtr<PlatformHandleDispatcher> dispatcher(
static_cast<PlatformHandleDispatcher*>(
« no previous file with comments | « mojo/edk/system/data_pipe_impl_unittest.cc ('k') | mojo/edk/system/remote_data_pipe_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698