Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1257)

Unified Diff: mojo/edk/system/remote_message_pipe_unittest.cc

Issue 1956703005: EDK: Check that handle rights are preserved in various tests. (Closed) Base URL: https://github.com/domokit/mojo.git@work787_edk_handle_13.8
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/edk/system/remote_data_pipe_impl_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/edk/system/remote_message_pipe_unittest.cc
diff --git a/mojo/edk/system/remote_message_pipe_unittest.cc b/mojo/edk/system/remote_message_pipe_unittest.cc
index f273445ee976d742f7a0caba21789fa13898d431..8d88b40abf38c7ff159f836b387f4176df1c3426 100644
--- a/mojo/edk/system/remote_message_pipe_unittest.cc
+++ b/mojo/edk/system/remote_message_pipe_unittest.cc
@@ -690,7 +690,8 @@ TEST_F(RemoteMessagePipeTest, HandlePassing) {
EXPECT_EQ(Dispatcher::Type::MESSAGE_PIPE,
read_handles[0].dispatcher->GetType());
- // TODO(vtl): Also check the rights here once they're actually preserved.
+ EXPECT_EQ(MessagePipeDispatcher::kDefaultHandleRights,
+ read_handles[0].rights);
dispatcher = RefPtr<MessagePipeDispatcher>(
static_cast<MessagePipeDispatcher*>(read_handles[0].dispatcher.get()));
@@ -879,7 +880,8 @@ TEST_F(RemoteMessagePipeTest, HandlePassingHalfClosed) {
EXPECT_EQ(Dispatcher::Type::MESSAGE_PIPE,
read_handles[0].dispatcher->GetType());
- // TODO(vtl): Also check the rights here once they're actually preserved.
+ EXPECT_EQ(MessagePipeDispatcher::kDefaultHandleRights,
+ read_handles[0].rights);
dispatcher = RefPtr<MessagePipeDispatcher>(
static_cast<MessagePipeDispatcher*>(read_handles[0].dispatcher.get()));
@@ -1012,7 +1014,8 @@ TEST_F(RemoteMessagePipeTest, SharedBufferPassing) {
EXPECT_EQ(Dispatcher::Type::SHARED_BUFFER,
read_handles[0].dispatcher->GetType());
- // TODO(vtl): Also check the rights here once they're actually preserved.
+ EXPECT_EQ(SharedBufferDispatcher::kDefaultHandleRights,
+ read_handles[0].rights);
dispatcher = RefPtr<SharedBufferDispatcher>(
static_cast<SharedBufferDispatcher*>(read_handles[0].dispatcher.get()));
@@ -1126,7 +1129,8 @@ TEST_F(RemoteMessagePipeTest, PlatformHandlePassing) {
EXPECT_EQ(Dispatcher::Type::PLATFORM_HANDLE,
read_handles[0].dispatcher->GetType());
- // TODO(vtl): Also check the rights here once they're actually preserved.
+ EXPECT_EQ(PlatformHandleDispatcher::kDefaultHandleRights,
+ read_handles[0].rights);
dispatcher = RefPtr<PlatformHandleDispatcher>(
static_cast<PlatformHandleDispatcher*>(read_handles[0].dispatcher.get()));
@@ -1265,7 +1269,8 @@ TEST_F(RemoteMessagePipeTest, PassMessagePipeHandleAcrossAndBack) {
EXPECT_EQ(Dispatcher::Type::MESSAGE_PIPE,
read_handles[0].dispatcher->GetType());
- // TODO(vtl): Also check the rights here once they're actually preserved.
+ EXPECT_EQ(MessagePipeDispatcher::kDefaultHandleRights,
+ read_handles[0].rights);
handle = std::move(read_handles[0]);
read_handles.clear();
@@ -1324,7 +1329,8 @@ TEST_F(RemoteMessagePipeTest, PassMessagePipeHandleAcrossAndBack) {
EXPECT_EQ(Dispatcher::Type::MESSAGE_PIPE,
read_handles[0].dispatcher->GetType());
- // TODO(vtl): Also check the rights here once they're actually preserved.
+ EXPECT_EQ(MessagePipeDispatcher::kDefaultHandleRights,
+ read_handles[0].rights);
dispatcher = RefPtr<MessagePipeDispatcher>(
static_cast<MessagePipeDispatcher*>(read_handles[0].dispatcher.get()));
read_handles.clear();
« no previous file with comments | « mojo/edk/system/remote_data_pipe_impl_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698