EDK: Check that handle rights are preserved in various tests.

mojo/edk/system/remote_message_pipe_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stdint.h>
 #include <stdio.h>
 #include <string.h>
 
 #include <memory>
 #include <utility>
@@ skipping 672 matching lines @@
                              &read_num_handles, MOJO_READ_MESSAGE_FLAG_NONE));
   EXPECT_EQ(sizeof(kHello), static_cast<size_t>(read_buffer_size));
   EXPECT_STREQ(kHello, read_buffer);
   EXPECT_EQ(1u, read_handles.size());
   EXPECT_EQ(1u, read_num_handles);
   ASSERT_TRUE(read_handles[0]);
   EXPECT_TRUE(read_handles[0].dispatcher->HasOneRef());
 
   EXPECT_EQ(Dispatcher::Type::MESSAGE_PIPE,
             read_handles[0].dispatcher->GetType());
-  // TODO(vtl): Also check the rights here once they're actually preserved.
+  EXPECT_EQ(MessagePipeDispatcher::kDefaultHandleRights,
+            read_handles[0].rights);
   dispatcher = RefPtr<MessagePipeDispatcher>(
       static_cast<MessagePipeDispatcher*>(read_handles[0].dispatcher.get()));
 
   // Add the waiter now, before it becomes readable to avoid a race.
   waiter.Init();
   ASSERT_EQ(MOJO_RESULT_OK,
             dispatcher->AddAwakable(&waiter, MOJO_HANDLE_SIGNAL_READABLE, 456,
                                     nullptr));
 
   // Write to "local_mp", port 1.
@@ skipping 168 matching lines @@
                              &read_num_handles, MOJO_READ_MESSAGE_FLAG_NONE));
   EXPECT_EQ(sizeof(kHello), static_cast<size_t>(read_buffer_size));
   EXPECT_STREQ(kHello, read_buffer);
   EXPECT_EQ(1u, read_handles.size());
   EXPECT_EQ(1u, read_num_handles);
   ASSERT_TRUE(read_handles[0]);
   EXPECT_TRUE(read_handles[0].dispatcher->HasOneRef());
 
   EXPECT_EQ(Dispatcher::Type::MESSAGE_PIPE,
             read_handles[0].dispatcher->GetType());
-  // TODO(vtl): Also check the rights here once they're actually preserved.
+  EXPECT_EQ(MessagePipeDispatcher::kDefaultHandleRights,
+            read_handles[0].rights);
   dispatcher = RefPtr<MessagePipeDispatcher>(
       static_cast<MessagePipeDispatcher*>(read_handles[0].dispatcher.get()));
 
   // |dispatcher| should already be readable and not writable.
   hss = dispatcher->GetHandleSignalsState();
   EXPECT_EQ(MOJO_HANDLE_SIGNAL_READABLE | MOJO_HANDLE_SIGNAL_PEER_CLOSED,
             hss.satisfied_signals);
   EXPECT_EQ(MOJO_HANDLE_SIGNAL_READABLE | MOJO_HANDLE_SIGNAL_PEER_CLOSED,
             hss.satisfiable_signals);
   // So read from it.
@@ skipping 112 matching lines @@
                              &read_num_handles, MOJO_READ_MESSAGE_FLAG_NONE));
   EXPECT_EQ(sizeof(kHello), static_cast<size_t>(read_buffer_size));
   EXPECT_STREQ(kHello, read_buffer);
   EXPECT_EQ(1u, read_handles.size());
   EXPECT_EQ(1u, read_num_handles);
   ASSERT_TRUE(read_handles[0]);
   EXPECT_TRUE(read_handles[0].dispatcher->HasOneRef());
 
   EXPECT_EQ(Dispatcher::Type::SHARED_BUFFER,
             read_handles[0].dispatcher->GetType());
-  // TODO(vtl): Also check the rights here once they're actually preserved.
+  EXPECT_EQ(SharedBufferDispatcher::kDefaultHandleRights,
+            read_handles[0].rights);
   dispatcher = RefPtr<SharedBufferDispatcher>(
       static_cast<SharedBufferDispatcher*>(read_handles[0].dispatcher.get()));
 
   // Make another mapping.
   std::unique_ptr<PlatformSharedBufferMapping> mapping1;
   EXPECT_EQ(MOJO_RESULT_OK, dispatcher->MapBuffer(
                                 0, 100, MOJO_MAP_BUFFER_FLAG_NONE, &mapping1));
   ASSERT_TRUE(mapping1);
   ASSERT_TRUE(mapping1->GetBase());
   ASSERT_EQ(100u, mapping1->GetLength());
@@ skipping 93 matching lines @@
                              &read_num_handles, MOJO_READ_MESSAGE_FLAG_NONE));
   EXPECT_EQ(sizeof(kWorld), static_cast<size_t>(read_buffer_size));
   EXPECT_STREQ(kWorld, read_buffer);
   EXPECT_EQ(1u, read_handles.size());
   EXPECT_EQ(1u, read_num_handles);
   ASSERT_TRUE(read_handles[0]);
   EXPECT_TRUE(read_handles[0].dispatcher->HasOneRef());
 
   EXPECT_EQ(Dispatcher::Type::PLATFORM_HANDLE,
             read_handles[0].dispatcher->GetType());
-  // TODO(vtl): Also check the rights here once they're actually preserved.
+  EXPECT_EQ(PlatformHandleDispatcher::kDefaultHandleRights,
+            read_handles[0].rights);
   dispatcher = RefPtr<PlatformHandleDispatcher>(
       static_cast<PlatformHandleDispatcher*>(read_handles[0].dispatcher.get()));
 
   ScopedPlatformHandle h = dispatcher->PassPlatformHandle();
   EXPECT_TRUE(h.is_valid());
 
   fp = FILEFromPlatformHandle(h.Pass(), "rb");
   EXPECT_FALSE(h.is_valid());
   EXPECT_TRUE(fp);
 
@@ skipping 118 matching lines @@
                              &read_num_handles, MOJO_READ_MESSAGE_FLAG_NONE));
   EXPECT_EQ(sizeof(kHello), static_cast<size_t>(read_buffer_size));
   EXPECT_STREQ(kHello, read_buffer);
   EXPECT_EQ(1u, read_handles.size());
   EXPECT_EQ(1u, read_num_handles);
   ASSERT_TRUE(read_handles[0]);
   EXPECT_TRUE(read_handles[0].dispatcher->HasOneRef());
 
   EXPECT_EQ(Dispatcher::Type::MESSAGE_PIPE,
             read_handles[0].dispatcher->GetType());
-  // TODO(vtl): Also check the rights here once they're actually preserved.
+  EXPECT_EQ(MessagePipeDispatcher::kDefaultHandleRights,
+            read_handles[0].rights);
   handle = std::move(read_handles[0]);
   read_handles.clear();
 
   // Now pass it back.
 
   // Prepare to wait on MP 0, port 0. (Add the waiter now. Otherwise, if we do
   // it later, it might already be readable.)
   waiter.Init();
   ASSERT_EQ(
       MOJO_RESULT_OK,
@@ skipping 38 matching lines @@
                              &read_num_handles, MOJO_READ_MESSAGE_FLAG_NONE));
   EXPECT_EQ(sizeof(kWorld), static_cast<size_t>(read_buffer_size));
   EXPECT_STREQ(kWorld, read_buffer);
   EXPECT_EQ(1u, read_handles.size());
   EXPECT_EQ(1u, read_num_handles);
   ASSERT_TRUE(read_handles[0]);
   EXPECT_TRUE(read_handles[0].dispatcher->HasOneRef());
 
   EXPECT_EQ(Dispatcher::Type::MESSAGE_PIPE,
             read_handles[0].dispatcher->GetType());
-  // TODO(vtl): Also check the rights here once they're actually preserved.
+  EXPECT_EQ(MessagePipeDispatcher::kDefaultHandleRights,
+            read_handles[0].rights);
   dispatcher = RefPtr<MessagePipeDispatcher>(
       static_cast<MessagePipeDispatcher*>(read_handles[0].dispatcher.get()));
   read_handles.clear();
 
   // Add the waiter now, before it becomes readable to avoid a race.
   waiter.Init();
   ASSERT_EQ(MOJO_RESULT_OK,
             dispatcher->AddAwakable(&waiter, MOJO_HANDLE_SIGNAL_READABLE, 789,
                                     nullptr));
 
@@ skipping 63 matching lines @@
   mp0->Close(0);
   mp1->Close(1);
   EXPECT_EQ(MOJO_RESULT_OK, dispatcher->Close());
   // Note that |local_mp|'s port 0 belong to |dispatcher|, which was closed.
   local_mp->Close(1);
 }
 
 }  // namespace
 }  // namespace system
 }  // namespace mojo