Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issue 1954953002: Add the concept of FloatRegister for all platforms. (Closed)

Created:
4 years, 7 months ago by bbudge
Modified:
4 years, 7 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add the concept of FloatRegister for all platforms. Changes some platform specific class names and uses typedefs to define FloatRegister, DoubleRegister, etc. This will be needed to do register allocation on ARM/MIPS where registers combine to form larger registers. LOG=N BUG=v8:4124 Committed: https://crrev.com/779fce378294dfc1f4685e274fd88b722b55d22d Cr-Commit-Position: refs/heads/master@{#36117}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -68 lines) Patch
M src/arm/assembler-arm.h View 1 6 chunks +16 lines, -5 lines 0 comments Download
M src/arm64/assembler-arm64.h View 2 chunks +7 lines, -1 line 0 comments Download
M src/ia32/assembler-ia32.h View 4 chunks +13 lines, -9 lines 0 comments Download
M src/mips/assembler-mips.h View 6 chunks +16 lines, -13 lines 0 comments Download
M src/mips64/assembler-mips64.h View 6 chunks +16 lines, -13 lines 0 comments Download
M src/ppc/assembler-ppc.h View 3 chunks +7 lines, -3 lines 0 comments Download
M src/s390/assembler-s390.h View 3 chunks +6 lines, -4 lines 0 comments Download
M src/x64/assembler-x64.h View 1 5 chunks +11 lines, -10 lines 0 comments Download
M src/x87/assembler-x87.h View 1 4 chunks +13 lines, -10 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
bbudge
4 years, 7 months ago (2016-05-09 17:13:08 UTC) #3
Benedikt Meurer
Nice. LGTM.
4 years, 7 months ago (2016-05-09 18:43:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1954953002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1954953002/20001
4 years, 7 months ago (2016-05-09 19:10:51 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-09 19:12:56 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-09 19:14:36 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/779fce378294dfc1f4685e274fd88b722b55d22d
Cr-Commit-Position: refs/heads/master@{#36117}

Powered by Google App Engine
This is Rietveld 408576698