Address some TODO(GYP)s in the GN build.

Address some TODO(GYP)s in the GN build.

Some were obsolete, some I implemented in this patch. Some I left as-is if they applied to Mac or iOS.

A few items are TODOs for when transition is complete. I changed these to "TODO(GYP_GONE)"

This patch only addresses ~25% of the build.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/f9427f9e3edb7be9bd540bb35b3d3156c08c3df6
Cr-Commit-Position: refs/heads/master@{#391943}

[brettw, 2016-05-04 19:31:15]

Description was changed from

==========
Address some TODO(GYP)s in the GN build.

Some were obsolete, some I implemented in this patch. Some I lfet as-is if they
applied to Mac or iOS.

A few items are TODOs for when transition is complete. I changed these to
"TODO(GYP_GONE)"

This patch only addresses ~25% of the build.
==========

to

==========
Address some TODO(GYP)s in the GN build.

Some were obsolete, some I implemented in this patch. Some I lfet as-is if they
applied to Mac or iOS.

A few items are TODOs for when transition is complete. I changed these to
"TODO(GYP_GONE)"

This patch only addresses ~25% of the build.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[brettw, 2016-05-04 19:49:43]

Patchset #1 (id:1) has been deleted

[brettw, 2016-05-04 19:51:27]

brettw@chromium.org changed reviewers:
+ brucedawson@chromium.org

[brettw, 2016-05-04 19:51:28]

Review PS#1 so you can see my comments, and then the diffs to #2.

https://codereview.chromium.org/1953523002/diff/20001/BUILD.gn
File BUILD.gn (left):

https://codereview.chromium.org/1953523002/diff/20001/BUILD.gn#oldcode116
BUILD.gn:116: # TODO(GYP): Add build steps that check and enforce this on the
bots.
We're never going to do this.

https://codereview.chromium.org/1953523002/diff/20001/BUILD.gn#oldcode364
BUILD.gn:364: deps += [ "//clank" ]  # TODO(GYP) ??
Dirk added this here:
https://codereview.chromium.org/953463003/diff/40001/BUILD.gn and I think it was
referring to consistency between GYP and GN.

https://codereview.chromium.org/1953523002/diff/20001/ash/BUILD.gn
File ash/BUILD.gn (left):

https://codereview.chromium.org/1953523002/diff/20001/ash/BUILD.gn#oldcode415
ash/BUILD.gn:415:
#'<(SHARED_INTERMEDIATE_DIR)/ui/resources/ui_unscaled_resources.rc',  TODO(GYP)
This comes automiatically from depending on ui/resources/ui_unscaled_resources

https://codereview.chromium.org/1953523002/diff/20001/base/BUILD.gn
File base/BUILD.gn (left):

https://codereview.chromium.org/1953523002/diff/20001/base/BUILD.gn#oldcode1531
base/BUILD.gn:1531: if (is_ios || is_android || is_win || (is_linux &&
!is_chromeos)) {
This seems to compile on ChromeOS which I think is everything.

https://codereview.chromium.org/1953523002/diff/20001/build/config/BUILD.gn
File build/config/BUILD.gn (left):

https://codereview.chromium.org/1953523002/diff/20001/build/config/BUILD.gn#o...
build/config/BUILD.gn:51: # TODO(brettw) this probably needs to be
parameterized.
We can parameterize this if and when we need it.

https://codereview.chromium.org/1953523002/diff/20001/build/config/BUILD.gn#o...
build/config/BUILD.gn:296: # TODO(GYP) The GYP build has "release_valgrind_build
== 0" for this
Valgrind is gone.

https://codereview.chromium.org/1953523002/diff/20001/build/config/compiler/B...
File build/config/compiler/BUILD.gn (left):

https://codereview.chromium.org/1953523002/diff/20001/build/config/compiler/B...
build/config/compiler/BUILD.gn:1338: # TODO(GYP): TODO(dpranke): Should these
only be on in an official
I think we should do WPO only in official.

https://codereview.chromium.org/1953523002/diff/20001/build/gn_migration.gypi
File build/gn_migration.gypi (left):

https://codereview.chromium.org/1953523002/diff/20001/build/gn_migration.gypi...
build/gn_migration.gypi:19: # above contracts.
Not going to do this.

https://codereview.chromium.org/1953523002/diff/20001/chrome/BUILD.gn
File chrome/BUILD.gn (left):

https://codereview.chromium.org/1953523002/diff/20001/chrome/BUILD.gn#oldcode135
chrome/BUILD.gn:135: # 'chrome_nacl_win64" TODO(GYP) bug 512869
This is nacl64.exe which gets build inside of native_client somewhere. The
packaging steps depend on it.

[brettw, 2016-05-04 19:51:32]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-04 19:51:58]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1953523002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1953523002/40001

[commit-bot: I haz the power, 2016-05-04 21:12:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-04 21:12:24]

Dry run: This issue passed the CQ dry run.

[brucedawson, 2016-05-04 21:46:26]

Description was changed from

==========
Address some TODO(GYP)s in the GN build.

Some were obsolete, some I implemented in this patch. Some I lfet as-is if they
applied to Mac or iOS.

A few items are TODOs for when transition is complete. I changed these to
"TODO(GYP_GONE)"

This patch only addresses ~25% of the build.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Address some TODO(GYP)s in the GN build.

Some were obsolete, some I implemented in this patch. Some I left as-is if they
applied to Mac or iOS.

A few items are TODOs for when transition is complete. I changed these to
"TODO(GYP_GONE)"

This patch only addresses ~25% of the build.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[brucedawson, 2016-05-05 15:58:53]

lgtm, with one question: I notice that there are several other commented out
msvs_shard references in .gn files. My assumption is that source sets make these
irrelevant in gn builds and that therefore they should be deleted, in a separate
CL.

[brettw, 2016-05-05 19:33:06]

Oh, my assumption was that the newer linker versions made these irrelevant. I
think source sets should not affect this.

[brettw, 2016-05-05 19:51:51]

Tracking down some shard blame leads to this CL:
https://codereview.chromium.org/123323002
On that scottmg says VS 2013 will fix the issue. So that explains why we haven't
seen problems in GN even though we don't support these. I'll remove all of them
in a followup.

[brettw, 2016-05-05 19:52:01]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2016-05-05 19:52:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1953523002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1953523002/40001

[commit-bot: I haz the power, 2016-05-05 20:00:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-05 20:00:35]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  ios-device-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)

[scottmg, 2016-05-05 20:10:30]

There's still a limit on .lib sizes, but I think it got larger in 2015 U2.

Do we have any with-symbols win gn bots yet that use goma (/Z7)? That was where
the problems normally showed up.

[brettw, 2016-05-05 20:16:10]

On 2016/05/05 20:10:30, scottmg wrote:
> There's still a limit on .lib sizes, but I think it got larger in 2015 U2.
> 
> Do we have any with-symbols win gn bots yet that use goma (/Z7)? That was
where
> the problems normally showed up.

Oh, source sets should definitely help with the problem if it
static-library-size related.

[brucedawson, 2016-05-05 20:33:13]

Yep, the msvs_shard hack is to deal with the limited size of static .lib files -
they are limited to 2 GB in VS 2015. I don't think that limit has increased
because I had to add a new msvs_shard a few weeks after the switch:
    crrev.com/1842203003

[brettw, 2016-05-05 21:32:08]

merge

[brettw, 2016-05-05 21:32:16]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-05-05 21:32:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
brucedawson@chromium.org
Link to the patchset: https://codereview.chromium.org/1953523002/#ps60001
(title: "merge")

[commit-bot: I haz the power, 2016-05-05 21:32:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1953523002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1953523002/60001

[commit-bot: I haz the power, 2016-05-05 23:19:05]

Description was changed from

==========
Address some TODO(GYP)s in the GN build.

Some were obsolete, some I implemented in this patch. Some I left as-is if they
applied to Mac or iOS.

A few items are TODOs for when transition is complete. I changed these to
"TODO(GYP_GONE)"

This patch only addresses ~25% of the build.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Address some TODO(GYP)s in the GN build.

Some were obsolete, some I implemented in this patch. Some I left as-is if they
applied to Mac or iOS.

A few items are TODOs for when transition is complete. I changed these to
"TODO(GYP_GONE)"

This patch only addresses ~25% of the build.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2016-05-05 23:19:06]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-05-05 23:20:18]

Description was changed from

==========
Address some TODO(GYP)s in the GN build.

Some were obsolete, some I implemented in this patch. Some I left as-is if they
applied to Mac or iOS.

A few items are TODOs for when transition is complete. I changed these to
"TODO(GYP_GONE)"

This patch only addresses ~25% of the build.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Address some TODO(GYP)s in the GN build.

Some were obsolete, some I implemented in this patch. Some I left as-is if they
applied to Mac or iOS.

A few items are TODOs for when transition is complete. I changed these to
"TODO(GYP_GONE)"

This patch only addresses ~25% of the build.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/f9427f9e3edb7be9bd540bb35b3d3156c08c3df6
Cr-Commit-Position: refs/heads/master@{#391943}
==========

[commit-bot: I haz the power, 2016-05-05 23:20:20]

Patchset 3 (id:??) landed as
https://crrev.com/f9427f9e3edb7be9bd540bb35b3d3156c08c3df6
Cr-Commit-Position: refs/heads/master@{#391943}