Address some TODO(GYP)s in the GN build.

build/config/BUILD.gn

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/allocator.gni")
 import("//build/config/chrome_build.gni")
 import("//build/config/chromecast_build.gni")
 import("//build/config/crypto.gni")
 import("//build/config/features.gni")
 import("//build/config/sanitizers/sanitizers.gni")
 import("//build/config/ui.gni")
 import("//build/toolchain/goma.gni")
 
 # One common error that happens is that GYP-generated headers within gen/ get
 # included rather than the GN-generated ones within gen/ subdirectories.
-# TODO(agrieve): Remove once GYP is gone (as well as exec_script exception).
+# TODO(GYP_GONE): Remove once GYP is gone (as well as exec_script exception).
 assert(
     exec_script("//build/dir_exists.py", [ "obj.host" ], "string") == "False",
     "GYP artifacts detected in $root_build_dir.$0x0A" +
         "You must wipe this directory before building with GN.")
 
 declare_args() {
   # When set (the default) enables C++ iterator debugging in debug builds.
   # Iterator debugging is always off in release builds (technically, this flag
   # affects the "debug" config, which is always available but applied by
   # default only in debug builds).
@@ skipping 14 matching lines @@
 }
 
 # TODO(brettw) Most of these should be removed. Instead of global feature
 # flags, we should have more modular flags that apply only to a target and its
 # dependents. For example, depending on the "x11" meta-target should define
 # USE_X11 for all dependents so that everything that could use X11 gets the
 # define, but anything that doesn't depend on X11 doesn't see it.
 #
 # For now we define these globally to match the current GYP build.
 config("feature_flags") {
-  # TODO(brettw) this probably needs to be parameterized.

[brettw, 2016/05/04 19:51:28]

We can parameterize this if and when we need it.

-  defines = [
-    "V8_DEPRECATION_WARNINGS",  # Don't use deprecated V8 APIs anywhere.
-  ]
+  # Don't use deprecated V8 APIs anywhere.
+  defines = [ "V8_DEPRECATION_WARNINGS" ]
   if (enable_mdns) {
     defines += [ "ENABLE_MDNS=1" ]
   }
   if (enable_notifications) {
     defines += [ "ENABLE_NOTIFICATIONS" ]
   }
   if (enable_pepper_cdms) {
     # TODO(brettw) should probably be "=1"
     defines += [ "ENABLE_PEPPER_CDMS" ]
   }
@@ skipping 221 matching lines @@
     # http://crbug.com/65151 .
     # TODO(phajdan.jr): Should we enable this for all of POSIX?
     defines += [ "_GLIBCXX_DEBUG=1" ]
   }
 }
 
 config("release") {
   defines = [ "NDEBUG" ]
 
   # Sanitizers.
-  # TODO(GYP) The GYP build has "release_valgrind_build == 0" for this

[brettw, 2016/05/04 19:51:28]

Valgrind is gone.

-  # condition. When Valgrind is set up, we need to do the same here.
   if (is_tsan) {
     defines += [
       "DYNAMIC_ANNOTATIONS_ENABLED=1",
       "WTF_USE_DYNAMIC_ANNOTATIONS=1",
     ]
   } else {
     defines += [ "NVALGRIND" ]
     if (!is_nacl) {
       # NaCl always enables dynamic annotations. Currently this value is set to
       # 1 for all .nexes.
@@ skipping 145 matching lines @@
       # file doesn't exist, no error will be generated (probably MS tested this
       # case but forgot the other one?). To reproduce this error, do a build,
       # then delete the precompile.c.obj file, then build again.
       cflags_c = [ "/wd4206" ]
     } else if (is_mac) {
       precompiled_header = "build/precompile.h"
       precompiled_source = "//build/precompile.h"
     }
   }
 }