Chromium Code Reviews

Unified Diff: chrome/browser/BUILD.gn

Issue 1953523002: Address some TODO(GYP)s in the GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
« no previous file with comments | « chrome/BUILD.gn ('k') | ui/resources/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/BUILD.gn
diff --git a/chrome/browser/BUILD.gn b/chrome/browser/BUILD.gn
index 4e6c216453e621da9ad5fcdf4889368511c25afa..e40bb4566696dc3109606f243b80ef8b47482392 100644
--- a/chrome/browser/BUILD.gn
+++ b/chrome/browser/BUILD.gn
@@ -814,13 +814,6 @@ source_set("browser") {
deps += [ ":rlz" ]
}
- # TODO(GYP)
- # Temporary fix to break the browser target into smaller chunks so it
- # will link with goma builds.
- #["OS=="win" and chromium_win_pch==0", {
- # "msvs_shard": 4,
- #}],
-
if (is_win) {
sources +=
rebase_path(gypi_values.chrome_browser_win_sources, ".", "//chrome")
« no previous file with comments | « chrome/BUILD.gn ('k') | ui/resources/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine