Shard browser.lib

Shard browser.lib

It fails to link if win_z7 = 1 (recommended goma setting).

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254345

[scottmg, 2014-01-06 21:58:27]

Otherwise, this lgtm if it makes it works on try jobs.

(If you're not in a rush and/or this causes problems, we'll hoepfully switch to
2013 in the next month-ish, which should hopefully lift this restriction
anyway.)

https://codereview.chromium.org/123323002/diff/40001/chrome/chrome_browser.gypi
File chrome/chrome_browser.gypi (right):

https://codereview.chromium.org/123323002/diff/40001/chrome/chrome_browser.gy...
chrome/chrome_browser.gypi:14: '<@(nacl_defines)',
i don't think this is doing anything here? wouldn't this have to be in
browser_real?

https://codereview.chromium.org/123323002/diff/40001/chrome/chrome_browser.gy...
chrome/chrome_browser.gypi:2677: '<@(nacl_defines)',
oh, it's also down here. yeah, remove from above then.

[jochen (gone - plz use gerrit), 2014-01-22 21:48:38]

i ran into the same problem today.

will you land your change?

[commit-bot: I haz the power, 2014-01-22 23:17:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/caitkp@chromium.org/123323002/160001

[commit-bot: I haz the power, 2014-01-22 23:52:05]

Retried try job too often on mac_rel for step(s) app_list_unittests,
cacheinvalidation_unittests, cc_unittests, check_deps, check_deps2git,
chromedriver_unittests, components_unittests, content_browsertests,
content_unittests, crypto_unittests, google_apis_unittests, gpu_unittests,
ipc_tests, jingle_unittests, media_unittests, message_center_unittests,
nacl_integration, ppapi_unittests, printing_unittests, remoting_unittests,
sql_unittests, sync_integration_tests, sync_unit_tests, telemetry_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2014-01-23 01:58:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/caitkp@chromium.org/123323002/160001

[commit-bot: I haz the power, 2014-01-23 03:03:52]

Retried try job too often on android_dbg for step(s) slave_steps
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...

[commit-bot: I haz the power, 2014-01-24 12:22:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/caitkp@chromium.org/123323002/160001

[commit-bot: I haz the power, 2014-01-24 13:24:21]

Retried try job too often on android_clang_dbg for step(s) slave_steps
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_cl...

[Cait (Slow), 2014-01-24 16:31:29]

On 2014/01/22 21:48:38, jochen wrote:
> i ran into the same problem today.
> 
> will you land your change?

jochen: I had planned to wait for the VS2013 switch and hope that that would
resolve things, as getting sharding working in proving harder than just adding
the msvs_shard option. Feel free to adopt the CL and see if you can get it
working though.

[jochen (gone - plz use gerrit), 2014-01-24 20:21:47]

On 2014/01/24 16:31:29, Cait Phillips wrote:
> On 2014/01/22 21:48:38, jochen wrote:
> > i ran into the same problem today.
> > 
> > will you land your change?
> 
> jochen: I had planned to wait for the VS2013 switch and hope that that would
> resolve things, as getting sharding working in proving harder than just adding
> the msvs_shard option. Feel free to adopt the CL and see if you can get it
> working though.

It doesn't :-(

With win_7z=1 I can't build on VS2013 either

[Cait (Slow), 2014-02-28 18:35:43]

+sky for chrome/ OWNERS 

Thanks!

[sky, 2014-02-28 21:44:35]

I don't think I get the subtlety of this patch.
+mark

[Mark Mentovai, 2014-02-28 21:49:17]

Does msvs_shard really require you to manually break it into a none-type target
and an implementation target? Yuck.

LGTM.

[sky, 2014-02-28 22:50:19]

Rubber stamp LGTM

[Cait (Slow), 2014-02-28 23:39:49]

On 2014/02/28 21:49:17, Mark Mentovai wrote:
> Does msvs_shard really require you to manually break it into a none-type
target
> and an implementation target? Yuck.

Not required, perse, but anything that depends on the browser target gets
terribly confused otherwise.
> 
> LGTM.

[Cait (Slow), 2014-02-28 23:39:58]

The CQ bit was checked by caitkp@chromium.org

[commit-bot: I haz the power, 2014-02-28 23:40:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/caitkp@chromium.org/123323002/940001

[commit-bot: I haz the power, 2014-03-01 01:08:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/caitkp@chromium.org/123323002/940001

[commit-bot: I haz the power, 2014-03-01 01:29:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/caitkp@chromium.org/123323002/940001

[commit-bot: I haz the power, 2014-03-01 04:05:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/caitkp@chromium.org/123323002/940001

[commit-bot: I haz the power, 2014-03-01 04:10:58]

Change committed as 254345