Address some TODO(GYP)s in the GN build.

BUILD.gn

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # This is the root build file for GN. GN will start processing by loading this
 # file, and recursively load all dependencies until all dependencies are either
 # resolved or known not to exist (which will cause the build to fail). So if
 # you add a new build file, there must be some path of dependencies from this
 # file to your new one or GN won't know about it.
 
@@ skipping 36 matching lines @@
 # "All" is an alias for "gn_all". It exists for bot compatibility w/ GYP for
 # the iOS bots and the official builders, but should not be generally used
 # during the GYP->GN migration.  We cannot guarantee that GN's "All" builds the
 # same set of targets as GYP's "All" does, because GYP's "All" supports
 # wildcards.
 #
 # Lastly, none of these targets are guaranteed to be the same as what ninja
 # will build with "all". For more on how "all" works and the differences in how
 # GYP and GN determine "all", see crbug.com/503241.
 #
-# TODO(GYP): crbug.com/481694. Make sure that the above is true and there are
-# scripts run on the bots that enforce this. Once the GYP migration is over, we
-# can collapse all of these targets as desired.
+# TODO(GYP_GONE): crbug.com/481694. Make sure that the above is true and there
+# are scripts run on the bots that enforce this. Once the GYP migration is
+# over, we can collapse all of these targets as desired.
 
 group("gn_all") {
   testonly = true
 
   deps = [
     ":both_gn_and_gyp",
     ":gn_only",
     ":gn_visibility",
   ]
 }
 
-# TODO(GYP): This target exists for compatibility with GYP, specifically
+# TODO(GYP_GONE): This target exists for compatibility with GYP, specifically
 # for the iOS bots and the official builders.
 group("All") {
   testonly = true
 
   deps = [
     ":gn_all",
   ]
 }
 
-# TODO(GYP): This target exists for compatibility with GYP for the builders.
-# For now, this builds everything. We should decide if we want to build less.
+# TODO(GYP_GONE): This target exists for compatibility with GYP for the
+# builders. For now, this builds everything. We should decide if we want to
+# build less.
 group("chromium_builder_tests") {
   testonly = true
 
   deps = [
     ":All",
   ]
 }
 
 if (is_chromeos) {
   group("chromiumos_preflight") {
@@ skipping 12 matching lines @@
       # Blocked on https://github.com/catapult-project/catapult/issues/2297
       #"//third_party/catapult/telemetry:bitmaptools",
       "//tools/perf/clear_system_cache",
     ]
   }
 }
 
 # The "both_gn_and_gyp" target should reflect every target that is built
 # in both the GN and GYP builds, and ideally it should match the
 # "both_gn_and_gyp" target in build/gn_migration.gypi line-for-line.
-#
-# TODO(GYP): Add build steps that check and enforce this on the bots.

[brettw, 2016/05/04 19:51:28]

We're never going to do this.

 group("both_gn_and_gyp") {
   testonly = true
   deps = [
     "//base:base_unittests",
     "//chrome/installer",
     "//components:components_unittests",
     "//net:net_unittests",
     "//skia:skia_unittests",
     "//sql:sql_unittests",
     "//sync:sync_unit_tests",
@@ skipping 227 matching lines @@
         "//content/shell/android:content_shell_test_apk",
         "//third_party/custom_tabs_client:custom_tabs_client_example_apk",
       ]
     }
 
     if (target_cpu != "x64") {
       deps += [ "//third_party/android_platform:android_relocation_packer_unittests($host_toolchain)" ]
     }
 
     if (has_chrome_android_internal) {
-      deps += [ "//clank" ]  # TODO(GYP) ??

[brettw, 2016/05/04 19:51:28]

Dirk added this here:
https://codereview.chromium.org/953463003/diff/40001/BUILD.gn and I think it was
referring to consistency between GYP and GN.

+      deps += [ "//clank" ]
     }
   }
 
-  if (is_linux || is_android) {  # TODO(GYP): || is_bsd?
+  if (is_linux || is_android) {
     deps += [
       "//breakpad:breakpad_unittests",
       "//breakpad:core-2-minidump",
       "//breakpad:generate_test_dump",
       "//breakpad:minidump-2-core",
     ]
   }
 
   if (is_chromeos) {
     deps += [
@@ skipping 122 matching lines @@
       }
     }
 
     if (media_use_ffmpeg && !is_android) {
       deps += [ "//media:ffmpeg_regression_tests" ]
     }
   }
 
   if (is_android || (is_linux && !is_chromeos)) {
     deps += [
-      # TODO(GYP): Figure out which of these should (and can) build
-      # under which other conditions.
       "//breakpad:dump_syms($host_toolchain)",
       "//breakpad:microdump_stackwalk($host_toolchain)",
       "//breakpad:minidump_dump($host_toolchain)",
       "//breakpad:minidump_stackwalk($host_toolchain)",
       "//components/network_hints/browser",
       "//content/public/app:browser",
       "//content/public/app:child",
-
-      # TODO(GYP): Remove this when the gles2 tests work
-      "//gpu/command_buffer/client:gles2_implementation_no_check",
       "//mojo/edk/test:mojo_public_system_perftests",
       "//services/shell/public/cpp",
       "//testing/gmock:gmock_main",
       "//third_party/codesighs:nm2tsv",
     ]
 
     if (!is_android) {
       deps += [
         "//build/sanitizers:copy_llvm_symbolizer",
         "//chrome/test:chrome_app_unittests",
-        "//gpu/khronos_glcts_support:khronos_glcts_test",  # TODO(GYP) crbug.com/471903 to make this complete.
+        "//gpu/khronos_glcts_support:khronos_glcts_test",
         "//media/cast:cast_benchmarks",
         "//media/cast:tap_proxy",
         "//skia:filter_fuzz_stub",
         "//skia:image_operations_bench",
         "//sync/tools:sync_client",
         "//sync/tools:sync_listen_notifications",
         "//third_party/sqlite:sqlite_shell",
         "//ui/keyboard:keyboard_unittests",
         "//ui/message_center:message_center_unittests",
         "//ui/snapshot:snapshot_unittests",
@@ skipping 408 matching lines @@
   assert(target_name != "")  # Mark as used.
   sources = invoker.actual_sources
   assert(
       sources == invoker.actual_sources,
       "Do not use a platform name in your output directory (found \"$root_build_dir\"). http://crbug.com/548283")
 }
 
 assert_valid_out_dir("_unused") {
   actual_sources = [ "$root_build_dir/foo" ]
 }