Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: build/config/compiler/BUILD.gn

Issue 1953523002: Address some TODO(GYP)s in the GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/android/rules.gni ('k') | build/gn_migration.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index 2f48477b9750977c999af1c6408cdb762ebba269..148abd61b2a48308d31f1b6625615075ce8d8ac9 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -45,7 +45,7 @@ declare_args() {
# Requires profiling to be set to true.
enable_full_stack_frames_for_profiling = false
- # TODO(GYP): We should be using 64-bit gold for linking on both 64-bit Linux
+ # TODO: We should be using 64-bit gold for linking on both 64-bit Linux
# and 32-bit linux; 32-bit Gold runs out of address-space on 32-bit builds.
# However, something isn't quite working right on the 32-bit builds.
use_gold =
@@ -1328,9 +1328,6 @@ config("optimize_max") {
# TODO(thakis): Remove is_clang here, https://crbug.com/598772
if (is_official_build && !is_clang) {
- # TODO(GYP): TODO(dpranke): Should these only be on in an official
- # build, or on all the time? For now we'll require official build so
- # that the compile is clean.
cflags += [
"/GL", # Whole program optimization.
« no previous file with comments | « build/config/android/rules.gni ('k') | build/gn_migration.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698