Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Side by Side Diff: BUILD.gn

Issue 1953523002: Address some TODO(GYP)s in the GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | ash/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # This is the root build file for GN. GN will start processing by loading this 5 # This is the root build file for GN. GN will start processing by loading this
6 # file, and recursively load all dependencies until all dependencies are either 6 # file, and recursively load all dependencies until all dependencies are either
7 # resolved or known not to exist (which will cause the build to fail). So if 7 # resolved or known not to exist (which will cause the build to fail). So if
8 # you add a new build file, there must be some path of dependencies from this 8 # you add a new build file, there must be some path of dependencies from this
9 # file to your new one or GN won't know about it. 9 # file to your new one or GN won't know about it.
10 10
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
47 # "All" is an alias for "gn_all". It exists for bot compatibility w/ GYP for 47 # "All" is an alias for "gn_all". It exists for bot compatibility w/ GYP for
48 # the iOS bots and the official builders, but should not be generally used 48 # the iOS bots and the official builders, but should not be generally used
49 # during the GYP->GN migration. We cannot guarantee that GN's "All" builds the 49 # during the GYP->GN migration. We cannot guarantee that GN's "All" builds the
50 # same set of targets as GYP's "All" does, because GYP's "All" supports 50 # same set of targets as GYP's "All" does, because GYP's "All" supports
51 # wildcards. 51 # wildcards.
52 # 52 #
53 # Lastly, none of these targets are guaranteed to be the same as what ninja 53 # Lastly, none of these targets are guaranteed to be the same as what ninja
54 # will build with "all". For more on how "all" works and the differences in how 54 # will build with "all". For more on how "all" works and the differences in how
55 # GYP and GN determine "all", see crbug.com/503241. 55 # GYP and GN determine "all", see crbug.com/503241.
56 # 56 #
57 # TODO(GYP): crbug.com/481694. Make sure that the above is true and there are 57 # TODO(GYP_GONE): crbug.com/481694. Make sure that the above is true and there
58 # scripts run on the bots that enforce this. Once the GYP migration is over, we 58 # are scripts run on the bots that enforce this. Once the GYP migration is
59 # can collapse all of these targets as desired. 59 # over, we can collapse all of these targets as desired.
60 60
61 group("gn_all") { 61 group("gn_all") {
62 testonly = true 62 testonly = true
63 63
64 deps = [ 64 deps = [
65 ":both_gn_and_gyp", 65 ":both_gn_and_gyp",
66 ":gn_only", 66 ":gn_only",
67 ":gn_visibility", 67 ":gn_visibility",
68 ] 68 ]
69 } 69 }
70 70
71 # TODO(GYP): This target exists for compatibility with GYP, specifically 71 # TODO(GYP_GONE): This target exists for compatibility with GYP, specifically
72 # for the iOS bots and the official builders. 72 # for the iOS bots and the official builders.
73 group("All") { 73 group("All") {
74 testonly = true 74 testonly = true
75 75
76 deps = [ 76 deps = [
77 ":gn_all", 77 ":gn_all",
78 ] 78 ]
79 } 79 }
80 80
81 # TODO(GYP): This target exists for compatibility with GYP for the builders. 81 # TODO(GYP_GONE): This target exists for compatibility with GYP for the
82 # For now, this builds everything. We should decide if we want to build less. 82 # builders. For now, this builds everything. We should decide if we want to
83 # build less.
83 group("chromium_builder_tests") { 84 group("chromium_builder_tests") {
84 testonly = true 85 testonly = true
85 86
86 deps = [ 87 deps = [
87 ":All", 88 ":All",
88 ] 89 ]
89 } 90 }
90 91
91 if (is_chromeos) { 92 if (is_chromeos) {
92 group("chromiumos_preflight") { 93 group("chromiumos_preflight") {
(...skipping 12 matching lines...) Expand all
105 # Blocked on https://github.com/catapult-project/catapult/issues/2297 106 # Blocked on https://github.com/catapult-project/catapult/issues/2297
106 #"//third_party/catapult/telemetry:bitmaptools", 107 #"//third_party/catapult/telemetry:bitmaptools",
107 "//tools/perf/clear_system_cache", 108 "//tools/perf/clear_system_cache",
108 ] 109 ]
109 } 110 }
110 } 111 }
111 112
112 # The "both_gn_and_gyp" target should reflect every target that is built 113 # The "both_gn_and_gyp" target should reflect every target that is built
113 # in both the GN and GYP builds, and ideally it should match the 114 # in both the GN and GYP builds, and ideally it should match the
114 # "both_gn_and_gyp" target in build/gn_migration.gypi line-for-line. 115 # "both_gn_and_gyp" target in build/gn_migration.gypi line-for-line.
115 #
116 # TODO(GYP): Add build steps that check and enforce this on the bots.
117 group("both_gn_and_gyp") { 116 group("both_gn_and_gyp") {
118 testonly = true 117 testonly = true
119 deps = [ 118 deps = [
120 "//base:base_unittests", 119 "//base:base_unittests",
121 "//chrome/installer", 120 "//chrome/installer",
122 "//components:components_unittests", 121 "//components:components_unittests",
123 "//net:net_unittests", 122 "//net:net_unittests",
124 "//skia:skia_unittests", 123 "//skia:skia_unittests",
125 "//sql:sql_unittests", 124 "//sql:sql_unittests",
126 "//sync:sync_unit_tests", 125 "//sync:sync_unit_tests",
(...skipping 227 matching lines...) Expand 10 before | Expand all | Expand 10 after
354 "//content/shell/android:content_shell_test_apk", 353 "//content/shell/android:content_shell_test_apk",
355 "//third_party/custom_tabs_client:custom_tabs_client_example_apk", 354 "//third_party/custom_tabs_client:custom_tabs_client_example_apk",
356 ] 355 ]
357 } 356 }
358 357
359 if (target_cpu != "x64") { 358 if (target_cpu != "x64") {
360 deps += [ "//third_party/android_platform:android_relocation_packer_unitte sts($host_toolchain)" ] 359 deps += [ "//third_party/android_platform:android_relocation_packer_unitte sts($host_toolchain)" ]
361 } 360 }
362 361
363 if (has_chrome_android_internal) { 362 if (has_chrome_android_internal) {
364 deps += [ "//clank" ] # TODO(GYP) ?? 363 deps += [ "//clank" ]
365 } 364 }
366 } 365 }
367 366
368 if (is_linux || is_android) { # TODO(GYP): || is_bsd? 367 if (is_linux || is_android) {
369 deps += [ 368 deps += [
370 "//breakpad:breakpad_unittests", 369 "//breakpad:breakpad_unittests",
371 "//breakpad:core-2-minidump", 370 "//breakpad:core-2-minidump",
372 "//breakpad:generate_test_dump", 371 "//breakpad:generate_test_dump",
373 "//breakpad:minidump-2-core", 372 "//breakpad:minidump-2-core",
374 ] 373 ]
375 } 374 }
376 375
377 if (is_chromeos) { 376 if (is_chromeos) {
378 deps += [ 377 deps += [
(...skipping 121 matching lines...) Expand 10 before | Expand all | Expand 10 after
500 } 499 }
501 } 500 }
502 501
503 if (media_use_ffmpeg && !is_android) { 502 if (media_use_ffmpeg && !is_android) {
504 deps += [ "//media:ffmpeg_regression_tests" ] 503 deps += [ "//media:ffmpeg_regression_tests" ]
505 } 504 }
506 } 505 }
507 506
508 if (is_android || (is_linux && !is_chromeos)) { 507 if (is_android || (is_linux && !is_chromeos)) {
509 deps += [ 508 deps += [
510 # TODO(GYP): Figure out which of these should (and can) build
511 # under which other conditions.
512 "//breakpad:dump_syms($host_toolchain)", 509 "//breakpad:dump_syms($host_toolchain)",
513 "//breakpad:microdump_stackwalk($host_toolchain)", 510 "//breakpad:microdump_stackwalk($host_toolchain)",
514 "//breakpad:minidump_dump($host_toolchain)", 511 "//breakpad:minidump_dump($host_toolchain)",
515 "//breakpad:minidump_stackwalk($host_toolchain)", 512 "//breakpad:minidump_stackwalk($host_toolchain)",
516 "//components/network_hints/browser", 513 "//components/network_hints/browser",
517 "//content/public/app:browser", 514 "//content/public/app:browser",
518 "//content/public/app:child", 515 "//content/public/app:child",
519
520 # TODO(GYP): Remove this when the gles2 tests work
521 "//gpu/command_buffer/client:gles2_implementation_no_check",
522 "//mojo/edk/test:mojo_public_system_perftests", 516 "//mojo/edk/test:mojo_public_system_perftests",
523 "//services/shell/public/cpp", 517 "//services/shell/public/cpp",
524 "//testing/gmock:gmock_main", 518 "//testing/gmock:gmock_main",
525 "//third_party/codesighs:nm2tsv", 519 "//third_party/codesighs:nm2tsv",
526 ] 520 ]
527 521
528 if (!is_android) { 522 if (!is_android) {
529 deps += [ 523 deps += [
530 "//build/sanitizers:copy_llvm_symbolizer", 524 "//build/sanitizers:copy_llvm_symbolizer",
531 "//chrome/test:chrome_app_unittests", 525 "//chrome/test:chrome_app_unittests",
532 "//gpu/khronos_glcts_support:khronos_glcts_test", # TODO(GYP) crbug.com /471903 to make this complete. 526 "//gpu/khronos_glcts_support:khronos_glcts_test",
533 "//media/cast:cast_benchmarks", 527 "//media/cast:cast_benchmarks",
534 "//media/cast:tap_proxy", 528 "//media/cast:tap_proxy",
535 "//skia:filter_fuzz_stub", 529 "//skia:filter_fuzz_stub",
536 "//skia:image_operations_bench", 530 "//skia:image_operations_bench",
537 "//sync/tools:sync_client", 531 "//sync/tools:sync_client",
538 "//sync/tools:sync_listen_notifications", 532 "//sync/tools:sync_listen_notifications",
539 "//third_party/sqlite:sqlite_shell", 533 "//third_party/sqlite:sqlite_shell",
540 "//ui/keyboard:keyboard_unittests", 534 "//ui/keyboard:keyboard_unittests",
541 "//ui/message_center:message_center_unittests", 535 "//ui/message_center:message_center_unittests",
542 "//ui/snapshot:snapshot_unittests", 536 "//ui/snapshot:snapshot_unittests",
(...skipping 408 matching lines...) Expand 10 before | Expand all | Expand 10 after
951 assert(target_name != "") # Mark as used. 945 assert(target_name != "") # Mark as used.
952 sources = invoker.actual_sources 946 sources = invoker.actual_sources
953 assert( 947 assert(
954 sources == invoker.actual_sources, 948 sources == invoker.actual_sources,
955 "Do not use a platform name in your output directory (found \"$root_build_ dir\"). http://crbug.com/548283") 949 "Do not use a platform name in your output directory (found \"$root_build_ dir\"). http://crbug.com/548283")
956 } 950 }
957 951
958 assert_valid_out_dir("_unused") { 952 assert_valid_out_dir("_unused") {
959 actual_sources = [ "$root_build_dir/foo" ] 953 actual_sources = [ "$root_build_dir/foo" ]
960 } 954 }
OLDNEW
« no previous file with comments | « no previous file | ash/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698