build/secondary/third_party/crashpad/crashpad/util/BUILD.gn - Issue 1953523002: Address some TODO(GYP)s in the GN build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/secondary/third_party/crashpad/crashpad/util/BUILD.gn

Issue 1953523002: Address some TODO(GYP)s in the GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: merge Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/secondary/third_party/crashpad/crashpad/util/BUILD.gn

diff --git a/build/secondary/third_party/crashpad/crashpad/util/BUILD.gn b/build/secondary/third_party/crashpad/crashpad/util/BUILD.gn

index 8c01267126da4fdf768acccc3a1616954659b39a..d29076f4b06588b2568ac6ffada086081a01cb80 100644

--- a/build/secondary/third_party/crashpad/crashpad/util/BUILD.gn

+++ b/build/secondary/third_party/crashpad/crashpad/util/BUILD.gn

@@ -228,7 +228,9 @@ source_set("util") {

"/wd4577", # 'noexcept' used with no exception handling mode specified.

]

- # TODO(GYP) UseSafeExceptionHandlers masm rule.

+ if (current_cpu == "x86") {

+ asmflags = [ "/safeseh" ]

+ }

} else if (is_mac) {

sources += get_target_outputs(":mig")

deps += [ ":mig" ]

« no previous file with comments | « build/gn_migration.gypi ('k') | cc/BUILD.gn » ('j') | no next file with comments »