Return bool rather than bitwise-and for FX_BOOL

Return bool rather than bitwise-and for FX_BOOL

Investigate results of:
  git grep -ni 'return [(]*[a-z0-9_]* &[^&]'
  git grep -ni 'BOOL.*= [(]*[a-z0-9_]* &[^&]'

Committed: https://pdfium.googlesource.com/pdfium/+/7d89e728a450c681c53d40d7f67ee2eef0400705

[Tom Sepez, 2016-05-03 22:51:32]

tsepez@chromium.org changed reviewers:
+ dsinclair@chromium.org

[Tom Sepez, 2016-05-03 22:51:33]

Dan, quick review.  I saw one of these near another change, and I wanted to try
and find others.

[Tom Sepez, 2016-05-03 23:07:07]

Description was changed from

==========
Return bool rather than bitwise-and for FX_BOOL

Investigate results of:
  git grep -ni 'return [a-z0-9_]* &[^&]'
==========

to

==========
Return bool rather than bitwise-and for FX_BOOL

Investigate results of:
  git grep -ni 'return [(]*[a-z0-9_]* &[^&]'
  git grep -ni 'BOOL.*= [(]*[a-z0-9_]* &[^&]'
==========

[dsinclair, 2016-05-04 13:11:51]

https://codereview.chromium.org/1951653002/diff/80001/core/fpdfapi/fpdf_rende...
File core/fpdfapi/fpdf_render/fpdf_render.cpp (right):

https://codereview.chromium.org/1951653002/diff/80001/core/fpdfapi/fpdf_rende...
core/fpdfapi/fpdf_render/fpdf_render.cpp:753: FX_BOOL isolated = !!(Transparency
& PDFTRANS_ISOLATED);
nit: bool

https://codereview.chromium.org/1951653002/diff/80001/core/fpdfapi/fpdf_rende...
File core/fpdfapi/fpdf_render/fpdf_render_image.cpp (right):

https://codereview.chromium.org/1951653002/diff/80001/core/fpdfapi/fpdf_rende...
core/fpdfapi/fpdf_render/fpdf_render_image.cpp:48: FX_BOOL bIsolated =
!!(Transparency & PDFTRANS_ISOLATED);
Move these down to ~69 where they're first used?

https://codereview.chromium.org/1951653002/diff/80001/core/fpdfapi/fpdf_rende...
core/fpdfapi/fpdf_render/fpdf_render_image.cpp:49: FX_BOOL bGroup =
!!(Transparency & PDFTRANS_GROUP);
nit: bool

https://codereview.chromium.org/1951653002/diff/80001/core/fpdfapi/fpdf_rende...
core/fpdfapi/fpdf_render/fpdf_render_image.cpp:70: FX_BOOL bGetBackGround =
nit: bool

https://codereview.chromium.org/1951653002/diff/80001/core/fxcrt/extension.h
File core/fxcrt/extension.h (right):

https://codereview.chromium.org/1951653002/diff/80001/core/fxcrt/extension.h#...
core/fxcrt/extension.h:243: FX_BOOL IsConsecutive() const override {
Can this return bool now?

https://codereview.chromium.org/1951653002/diff/80001/core/fxge/ge/fx_ge_text...
File core/fxge/ge/fx_ge_text.cpp (right):

https://codereview.chromium.org/1951653002/diff/80001/core/fxge/ge/fx_ge_text...
core/fxge/ge/fx_ge_text.cpp:416: FX_BOOL bBGRStripe = !!(text_flags &
FXTEXT_BGR_STRIPE);
nit: bool

https://codereview.chromium.org/1951653002/diff/80001/xfa/fwl/basewidget/fwl_...
File xfa/fwl/basewidget/fwl_listboximp.cpp (right):

https://codereview.chromium.org/1951653002/diff/80001/xfa/fwl/basewidget/fwl_...
xfa/fwl/basewidget/fwl_listboximp.cpp:402: if (!(dwState &
FWL_ITEMSTATE_LTB_Selected)) {
nit: no {}'s

https://codereview.chromium.org/1951653002/diff/80001/xfa/fwl/core/fwl_widget...
File xfa/fwl/core/fwl_widgetmgrimp.cpp (right):

https://codereview.chromium.org/1951653002/diff/80001/xfa/fwl/core/fwl_widget...
xfa/fwl/core/fwl_widgetmgrimp.cpp:673: FX_BOOL CFWL_WidgetMgr::IsFormDisabled()
{
nit: bool?

https://codereview.chromium.org/1951653002/diff/80001/xfa/fxfa/app/xfa_ffwidg...
File xfa/fxfa/app/xfa_ffwidget.cpp (right):

https://codereview.chromium.org/1951653002/diff/80001/xfa/fxfa/app/xfa_ffwidg...
xfa/fxfa/app/xfa_ffwidget.cpp:175: FX_BOOL CXFA_FFWidget::IsFocused() {
nit: Can these return bool (possibly in a followup?)

https://codereview.chromium.org/1951653002/diff/80001/xfa/fxfa/app/xfa_ffwidg...
xfa/fxfa/app/xfa_ffwidget.cpp:403: FX_BOOL
CXFA_FFWidget::IsMatchVisibleStatus(uint32_t dwStatus) {
nit: bool?

[Tom Sepez, 2016-05-04 20:21:26]

https://codereview.chromium.org/1951653002/diff/80001/core/fpdfapi/fpdf_rende...
File core/fpdfapi/fpdf_render/fpdf_render.cpp (right):

https://codereview.chromium.org/1951653002/diff/80001/core/fpdfapi/fpdf_rende...
core/fpdfapi/fpdf_render/fpdf_render.cpp:753: FX_BOOL isolated = !!(Transparency
& PDFTRANS_ISOLATED);
On 2016/05/04 13:11:50, dsinclair wrote:
> nit: bool

Done.

https://codereview.chromium.org/1951653002/diff/80001/core/fpdfapi/fpdf_rende...
File core/fpdfapi/fpdf_render/fpdf_render_image.cpp (right):

https://codereview.chromium.org/1951653002/diff/80001/core/fpdfapi/fpdf_rende...
core/fpdfapi/fpdf_render/fpdf_render_image.cpp:48: FX_BOOL bIsolated =
!!(Transparency & PDFTRANS_ISOLATED);
On 2016/05/04 13:11:50, dsinclair wrote:
> Move these down to ~69 where they're first used?

Done.

https://codereview.chromium.org/1951653002/diff/80001/core/fpdfapi/fpdf_rende...
core/fpdfapi/fpdf_render/fpdf_render_image.cpp:49: FX_BOOL bGroup =
!!(Transparency & PDFTRANS_GROUP);
On 2016/05/04 13:11:50, dsinclair wrote:
> nit: bool

Done.

https://codereview.chromium.org/1951653002/diff/80001/core/fpdfapi/fpdf_rende...
core/fpdfapi/fpdf_render/fpdf_render_image.cpp:70: FX_BOOL bGetBackGround =
On 2016/05/04 13:11:50, dsinclair wrote:
> nit: bool

Done.

https://codereview.chromium.org/1951653002/diff/80001/core/fxcrt/extension.h
File core/fxcrt/extension.h (right):

https://codereview.chromium.org/1951653002/diff/80001/core/fxcrt/extension.h#...
core/fxcrt/extension.h:243: FX_BOOL IsConsecutive() const override {
On 2016/05/04 13:11:50, dsinclair wrote:
> Can this return bool now?
Yes, but all the ripples ... didn't want to hunt down all the overriders.

https://codereview.chromium.org/1951653002/diff/80001/core/fxge/ge/fx_ge_text...
File core/fxge/ge/fx_ge_text.cpp (right):

https://codereview.chromium.org/1951653002/diff/80001/core/fxge/ge/fx_ge_text...
core/fxge/ge/fx_ge_text.cpp:416: FX_BOOL bBGRStripe = !!(text_flags &
FXTEXT_BGR_STRIPE);
On 2016/05/04 13:11:51, dsinclair wrote:
> nit: bool

Done.

https://codereview.chromium.org/1951653002/diff/80001/xfa/fwl/basewidget/fwl_...
File xfa/fwl/basewidget/fwl_listboximp.cpp (right):

https://codereview.chromium.org/1951653002/diff/80001/xfa/fwl/basewidget/fwl_...
xfa/fwl/basewidget/fwl_listboximp.cpp:402: if (!(dwState &
FWL_ITEMSTATE_LTB_Selected)) {
On 2016/05/04 13:11:51, dsinclair wrote:
> nit: no {}'s

Done.

https://codereview.chromium.org/1951653002/diff/80001/xfa/fwl/core/fwl_widget...
File xfa/fwl/core/fwl_widgetmgrimp.cpp (right):

https://codereview.chromium.org/1951653002/diff/80001/xfa/fwl/core/fwl_widget...
xfa/fwl/core/fwl_widgetmgrimp.cpp:673: FX_BOOL CFWL_WidgetMgr::IsFormDisabled()
{
On 2016/05/04 13:11:51, dsinclair wrote:
> nit: bool?

Done.

https://codereview.chromium.org/1951653002/diff/80001/xfa/fxfa/app/xfa_ffwidg...
File xfa/fxfa/app/xfa_ffwidget.cpp (right):

https://codereview.chromium.org/1951653002/diff/80001/xfa/fxfa/app/xfa_ffwidg...
xfa/fxfa/app/xfa_ffwidget.cpp:175: FX_BOOL CXFA_FFWidget::IsFocused() {
On 2016/05/04 13:11:51, dsinclair wrote:
> nit: Can these return bool (possibly in a followup?)

This one yes, the others have overrides .

https://codereview.chromium.org/1951653002/diff/80001/xfa/fxfa/app/xfa_ffwidg...
xfa/fxfa/app/xfa_ffwidget.cpp:403: FX_BOOL
CXFA_FFWidget::IsMatchVisibleStatus(uint32_t dwStatus) {
On 2016/05/04 13:11:51, dsinclair wrote:
> nit: bool?

Done.

[dsinclair, 2016-05-04 20:25:45]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-05-04 20:25:46]

lgtm

[commit-bot: I haz the power, 2016-05-04 20:25:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1951653002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1951653002/100001

[commit-bot: I haz the power, 2016-05-04 20:38:14]

Description was changed from

==========
Return bool rather than bitwise-and for FX_BOOL

Investigate results of:
  git grep -ni 'return [(]*[a-z0-9_]* &[^&]'
  git grep -ni 'BOOL.*= [(]*[a-z0-9_]* &[^&]'
==========

to

==========
Return bool rather than bitwise-and for FX_BOOL

Investigate results of:
  git grep -ni 'return [(]*[a-z0-9_]* &[^&]'
  git grep -ni 'BOOL.*= [(]*[a-z0-9_]* &[^&]'

Committed:
https://pdfium.googlesource.com/pdfium/+/7d89e728a450c681c53d40d7f67ee2eef040...
==========

[commit-bot: I haz the power, 2016-05-04 20:38:15]

Committed patchset #6 (id:100001) as
https://pdfium.googlesource.com/pdfium/+/7d89e728a450c681c53d40d7f67ee2eef040...