core/fxge/ge/fx_ge_text.cpp - Issue 1951653002: Return bool rather than bitwise-and for FX_BOOL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fxge/ge/fx_ge_text.cpp

Issue 1951653002: Return bool rather than bitwise-and for FX_BOOL (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: More bool, fix nits. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fxge/ge/fx_ge_text.cpp

diff --git a/core/fxge/ge/fx_ge_text.cpp b/core/fxge/ge/fx_ge_text.cpp

index 9ad93d872a65ce9f35a9bcf675ef30c0b46fc342..3372b7f95dd0ac341b020db850faf51ba14560a6 100644

--- a/core/fxge/ge/fx_ge_text.cpp

+++ b/core/fxge/ge/fx_ge_text.cpp

@@ -413,7 +413,7 @@ FX_BOOL CFX_RenderDevice::DrawNormalText(int nChars,

}

continue;

}

- FX_BOOL bBGRStripe = text_flags & FXTEXT_BGR_STRIPE;

+ bool bBGRStripe = !!(text_flags & FXTEXT_BGR_STRIPE);

ncols /= 3;

int x_subpixel = (int)(glyph.m_fOriginX * 3) % 3;

uint8_t* src_buf = pGlyph->GetBuffer();

« no previous file with comments | « core/fxcrt/extension.h ('k') | xfa/fwl/basewidget/fwl_comboboximp.cpp » ('j') | no next file with comments »