xfa/fxfa/include/xfa_ffwidget.h - Issue 1951653002: Return bool rather than bitwise-and for FX_BOOL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fxfa/include/xfa_ffwidget.h

Issue 1951653002: Return bool rather than bitwise-and for FX_BOOL (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: More bool, fix nits. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fxfa/include/xfa_ffwidget.h

diff --git a/xfa/fxfa/include/xfa_ffwidget.h b/xfa/fxfa/include/xfa_ffwidget.h

index 74e4c84c4de4e72f57a925505411adfb89e18e10..783bac5ab455784a8a99376f001ea3a1c777f275 100644

--- a/xfa/fxfa/include/xfa_ffwidget.h

+++ b/xfa/fxfa/include/xfa_ffwidget.h

@@ -119,7 +119,7 @@ class CXFA_FFWidget : public CFX_PrivateData, public CXFA_ContentLayoutItem {

void InvalidateWidget(const CFX_RectF* pRect = NULL);

void AddInvalidateRect(const CFX_RectF* pRect = NULL);

FX_BOOL GetCaptionText(CFX_WideString& wsCap);

- FX_BOOL IsFocused();

+ bool IsFocused();

void Rotate2Normal(FX_FLOAT& fx, FX_FLOAT& fy);

void GetRotateMatrix(CFX_Matrix& mt);

FX_BOOL IsLayoutRectEmpty();

@@ -136,7 +136,7 @@ class CXFA_FFWidget : public CFX_PrivateData, public CXFA_ContentLayoutItem {

void GetMinMaxWidth(FX_FLOAT fMinWidth, FX_FLOAT fMaxWidth);

void GetMinMaxHeight(FX_FLOAT fMinHeight, FX_FLOAT fMaxHeight);

void GetRectWithoutRotate(CFX_RectF& rtWidget);

- FX_BOOL IsMatchVisibleStatus(uint32_t dwStatus);

+ bool IsMatchVisibleStatus(uint32_t dwStatus);

void EventKillFocus();

FX_BOOL IsButtonDown();

« no previous file with comments | « xfa/fxfa/app/xfa_ffwidget.cpp ('k') | xfa/fxfa/parser/xfa_document_imp.cpp » ('j') | no next file with comments »