xfa/fxfa/parser/xfa_document_imp.cpp - Issue 1951653002: Return bool rather than bitwise-and for FX_BOOL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fxfa/parser/xfa_document_imp.cpp

Issue 1951653002: Return bool rather than bitwise-and for FX_BOOL (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: More bool, fix nits. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fxfa/parser/xfa_document_imp.cpp

diff --git a/xfa/fxfa/parser/xfa_document_imp.cpp b/xfa/fxfa/parser/xfa_document_imp.cpp

index 083fe24a7ee09894b4a0676f954d07ebda959404..3601c5b621a0895e9da06dafde800c57c5a35179 100644

--- a/xfa/fxfa/parser/xfa_document_imp.cpp

+++ b/xfa/fxfa/parser/xfa_document_imp.cpp

@@ -198,7 +198,7 @@ void CXFA_Document::SetFlag(uint32_t dwFlag, FX_BOOL bOn) {

}

FX_BOOL CXFA_Document::IsInteractive() {

if (m_dwDocFlags & XFA_DOCFLAG_HasInteractive) {

- return m_dwDocFlags & XFA_DOCFLAG_Interactive;

+ return !!(m_dwDocFlags & XFA_DOCFLAG_Interactive);

}

CXFA_Node* pConfig = ToNode(GetXFAObject(XFA_HASHCODE_Config));

if (!pConfig) {

« no previous file with comments | « xfa/fxfa/include/xfa_ffwidget.h ('k') | no next file » | no next file with comments »