xfa/fwl/basewidget/fwl_editimp.cpp - Issue 1951653002: Return bool rather than bitwise-and for FX_BOOL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fwl/basewidget/fwl_editimp.cpp

Issue 1951653002: Return bool rather than bitwise-and for FX_BOOL (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: More bool, fix nits. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fwl/basewidget/fwl_editimp.cpp

diff --git a/xfa/fwl/basewidget/fwl_editimp.cpp b/xfa/fwl/basewidget/fwl_editimp.cpp

index 8b4dd39321cd95cbe771494d31d6f5c5e0a2b1e3..a80b89f9a74e2190685df726d7b6acc7b14b1049 100644

--- a/xfa/fwl/basewidget/fwl_editimp.cpp

+++ b/xfa/fwl/basewidget/fwl_editimp.cpp

@@ -1831,7 +1831,7 @@ void CFWL_EditImpDelegate::DoButtonDown(CFWL_MsgMouse* pMsg) {

}

void CFWL_EditImpDelegate::OnFocusChanged(CFWL_Message* pMsg, FX_BOOL bSet) {

uint32_t dwStyleEx = m_pOwner->GetStylesEx();

- FX_BOOL bRepaint = dwStyleEx & FWL_STYLEEXT_EDT_InnerCaret;

+ bool bRepaint = !!(dwStyleEx & FWL_STYLEEXT_EDT_InnerCaret);

if (bSet) {

m_pOwner->m_pProperties->m_dwStates |= FWL_WGTSTATE_Focused;

if (!m_pOwner->m_pEdtEngine) {

« no previous file with comments | « xfa/fwl/basewidget/fwl_comboboximp.cpp ('k') | xfa/fwl/basewidget/fwl_listboximp.cpp » ('j') | no next file with comments »