xfa/fwl/theme/cfwl_checkboxtp.cpp - Issue 1951653002: Return bool rather than bitwise-and for FX_BOOL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fwl/theme/cfwl_checkboxtp.cpp

Issue 1951653002: Return bool rather than bitwise-and for FX_BOOL (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: More bool, fix nits. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fwl/theme/cfwl_checkboxtp.cpp

diff --git a/xfa/fwl/theme/cfwl_checkboxtp.cpp b/xfa/fwl/theme/cfwl_checkboxtp.cpp

index ac94c80d6d168bc88af4611a79dfb5064b2ec591..a6d70eb452f843425fa285192d22cb4a047f2741 100644

--- a/xfa/fwl/theme/cfwl_checkboxtp.cpp

+++ b/xfa/fwl/theme/cfwl_checkboxtp.cpp

@@ -114,7 +114,7 @@ void CFWL_CheckBoxTP::DrawBoxBk(IFWL_Widget* pWidget,

path.Create();

FX_FLOAT fRight = pRect->right();

FX_FLOAT fBottom = pRect->bottom();

- FX_BOOL bClipSign = dwStates & CFWL_PartState_Hovered;

+ bool bClipSign = !!(dwStates & CFWL_PartState_Hovered);

if ((dwStyleEx == FWL_STYLEEXT_CKB_ShapeSolidSquare) ||

(dwStyleEx == FWL_STYLEEXT_CKB_ShapeSunkenSquare)) {

path.AddRectangle(pRect->left, pRect->top, pRect->width, pRect->height);

« no previous file with comments | « xfa/fwl/core/fwl_widgetmgrimp.cpp ('k') | xfa/fxfa/app/xfa_ffwidget.cpp » ('j') | no next file with comments »